From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE717C433E7 for ; Mon, 12 Oct 2020 16:22:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 910FE20838 for ; Mon, 12 Oct 2020 16:22:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390130AbgJLQWo (ORCPT ); Mon, 12 Oct 2020 12:22:44 -0400 Received: from mail.kernel.org ([198.145.29.99]:60144 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390114AbgJLQWn (ORCPT ); Mon, 12 Oct 2020 12:22:43 -0400 Received: from gaia (unknown [95.149.105.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6D7A5206CB; Mon, 12 Oct 2020 16:22:41 +0000 (UTC) Date: Mon, 12 Oct 2020 17:22:39 +0100 From: Catalin Marinas To: Ard Biesheuvel Cc: Linux ARM , ACPI Devel Maling List , Will Deacon , Jeremy Linton , Lorenzo Pieralisi , Nicolas Saenz Julienne , Rob Herring , Christoph Hellwig , Robin Murphy , Hanjun Guo , Sudeep Holla , Anshuman Khandual Subject: Re: [PATCH] arm64: mm: set ZONE_DMA size based on early IORT scan Message-ID: <20201012162238.GC6493@gaia> References: <20201010093153.30177-1-ardb@kernel.org> <20201012092821.GB9844@gaia> <20201012112453.GD9844@gaia> <20201012154954.GB6493@gaia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Mon, Oct 12, 2020 at 05:55:45PM +0200, Ard Biesheuvel wrote: > On Mon, 12 Oct 2020 at 17:50, Catalin Marinas wrote: > > > > On Mon, Oct 12, 2020 at 12:43:05PM +0200, Ard Biesheuvel wrote: > > > > > Also, could someone give an executive summary of why it matters where > > > > > the crashkernel is loaded? As far as I can tell, reserve_crashkernel() > > > > > only allocates memory for the kernel's executable image itself, which > > > > > can usually be loaded anywhere in memory. I could see how a > > > > > crashkernel might need some DMA'able memory if it needs to use the > > > > > hardware, but I don't think that is what is going on here. [...] > > However, the crashkernel=... range is meant for sufficiently large > > reservation to be able to run the kdump kernel, not just load the image. > > Sure. But I was referring to the requirement that it is loaded low in > memory. Unless I am misunderstanding something, all we need for the > crashkernel to be able to operate is some ZONE_DMA memory in case it > is needed by the hardware, and beyond that, it could happily live > anywhere in memory. Yes, the crash kernel doesn't need to be loaded in the low memory. But some low memory needs to end up in its perceived System RAM. That's what Chen is trying to do with this series: https://lore.kernel.org/linux-arm-kernel/20200907134745.25732-1-chenzhou10@huawei.com/ It reserves the normal crashkernel memory at some high address range with a small block (currently proposed as 256MB similar to x86) in the "low" range. This "low" range for arm64 currently means below 1GB but it's only RPi4 that needs it this low, all other platforms are fine with the full low 32-bit range. If it's not doable in a nice way, we'll just leave with this permanent 1GB ZONE_DMA and hope we won't get platforms requiring an even smaller one. There's also the option of ignoring kdump on RPi4, make ZONE_DMA depend on !CRASH_DUMP and the "low" reservations can use the full 32-bit range since the kdump kernel won't need <30-bit addresses. -- Catalin