From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: linux-acpi@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>
Subject: [PATCH v5 1/7] resource: Simplify region_intersects() by reducing conditionals
Date: Tue, 3 Nov 2020 22:36:49 +0200 [thread overview]
Message-ID: <20201103203655.17701-2-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20201103203655.17701-1-andriy.shevchenko@linux.intel.com>
Now we have for 'other' and 'type' variables
other type return
0 0 REGION_DISJOINT
0 x REGION_INTERSECTS
x 0 REGION_DISJOINT
x x REGION_MIXED
Obviously it's easier to check 'type' for 0 first instead of
currently checked 'other'.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
kernel/resource.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/kernel/resource.c b/kernel/resource.c
index 3ae2f56cc79d..82df80417489 100644
--- a/kernel/resource.c
+++ b/kernel/resource.c
@@ -557,13 +557,13 @@ int region_intersects(resource_size_t start, size_t size, unsigned long flags,
}
read_unlock(&resource_lock);
- if (other == 0)
- return type ? REGION_INTERSECTS : REGION_DISJOINT;
+ if (type == 0)
+ return REGION_DISJOINT;
- if (type)
- return REGION_MIXED;
+ if (other == 0)
+ return REGION_INTERSECTS;
- return REGION_DISJOINT;
+ return REGION_MIXED;
}
EXPORT_SYMBOL_GPL(region_intersects);
--
2.28.0
next prev parent reply other threads:[~2020-11-03 22:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-03 20:36 [PATCH v5 0/7] resource: introduce union(), intersection() API Andy Shevchenko
2020-11-03 20:36 ` Andy Shevchenko [this message]
2020-11-03 20:36 ` [PATCH v5 2/7] resource: Group resource_overlaps() with other inline helpers Andy Shevchenko
2020-11-03 20:36 ` [PATCH v5 3/7] resource: Introduce resource_union() for overlapping resources Andy Shevchenko
2020-11-03 20:36 ` [PATCH v5 4/7] resource: Introduce resource_intersection() " Andy Shevchenko
2020-11-03 20:36 ` [PATCH v5 5/7] resource: Add test cases for new resource API Andy Shevchenko
2020-11-03 20:36 ` [PATCH v5 6/7] PCI/ACPI: Replace open coded variant of resource_union() Andy Shevchenko
2020-11-03 20:36 ` [PATCH v5 7/7] ACPI: watchdog: " Andy Shevchenko
2020-11-03 20:47 ` [PATCH v5 0/7] resource: introduce union(), intersection() API Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201103203655.17701-2-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox