From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3319DC55178 for ; Thu, 5 Nov 2020 15:55:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DB83B2078E for ; Thu, 5 Nov 2020 15:55:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730977AbgKEPzt (ORCPT ); Thu, 5 Nov 2020 10:55:49 -0500 Received: from mga06.intel.com ([134.134.136.31]:51983 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730862AbgKEPzt (ORCPT ); Thu, 5 Nov 2020 10:55:49 -0500 IronPort-SDR: 8AdFpAZ2AyZ9mMMdphbaxTQ5OYBtRyU4sEUcgX2sUk0UaKBzCNAKXAs+cWm+TL1g0/BKMtFysI GJTX6EdVd03g== X-IronPort-AV: E=McAfee;i="6000,8403,9795"; a="231029681" X-IronPort-AV: E=Sophos;i="5.77,453,1596524400"; d="scan'208";a="231029681" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Nov 2020 07:55:38 -0800 IronPort-SDR: 8EJwKveD0CRLeVwn2VGoK8AXFHdWOkAblbTWtxFo4B183A9w9Y6xtWkeqVDcHSLhZvHTq2Jyw2 N/G3Cj9G2r1A== X-IronPort-AV: E=Sophos;i="5.77,453,1596524400"; d="scan'208";a="529465984" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Nov 2020 07:55:36 -0800 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1kahct-00468E-Bh; Thu, 05 Nov 2020 17:56:39 +0200 Date: Thu, 5 Nov 2020 17:56:39 +0200 From: Andy Shevchenko To: "Rafael J. Wysocki" Cc: Flavio Suligoi , "linux-acpi@vger.kernel.org" , Mika Westerberg Subject: Re: How to add the "gpio-line-names" property in a PCI gpio expander Message-ID: <20201105155639.GV4077@smile.fi.intel.com> References: <98acf6339a1b43d6a38f867069088530@asem.it> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Thu, Nov 05, 2020 at 12:51:18PM +0100, Rafael J. Wysocki wrote: > CC Mika and Andy who should be more familiar with that problem space than I am. I believe I have explained this in the [1]. Perhaps it's about how to find proper device node / ACPI path of the devices in question? [1]: https://lore.kernel.org/linux-gpio/9152bb8be33e4192a7766eb53c6ca9af@asem.it/ > On Thu, Nov 5, 2020 at 10:46 AM Flavio Suligoi wrote: > > > > Hi all, > > > > I'm working to introduce the "gpio-line-names" property in the ACPI > > configuration of the BIOS of our x86 boards (we can customize the BIOS of our > > boards). > > > > All is ok for the gpiochips related to the Intel chipset and some I2C gpio > > expanders. I have inserted the _DSD as described in the Linux documentation. > > > > In one of our boards we have an add-on PCI board, with a PCI serial device > > Exar XR17V352. This device also contains 16 gpios. > > The exar device drivers work good, both the "8250_exar" and the "gpio_exar", and > > I can manage the exar's gpios correctly. > > The problem is how to assign the gpio-line-names property to a PCI gpio > > expanders like this. > > > > I tried adding a new device in my ACPI configuration, as: > > > > Device (EXAR) > > { > > Name (_HID, "13A80352") > > Name (_STR, Unicode ("STR - Exar GPIOs")) // _STR: Description String > > > > Name (_DSD, Package () { > > ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), > > Package () { > > Package () { > > "gpio-line-names", > > Package () { > > "exar_0", > > "exar_1", > > "exar_2", > > "exar_3", > > ... > > } > > } > > } > > }) > > } > > > > but I have no result. > > Does anyone have a suggestion? > > > > Thanks, > > > > Flavio -- With Best Regards, Andy Shevchenko