From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10E77C388F2 for ; Fri, 6 Nov 2020 07:23:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9A31920A8B for ; Fri, 6 Nov 2020 07:23:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604647404; bh=bZJj9WzPD8oFm2s1+akaeCuY5a6U01z3MrdDbjK8/Wg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=zolNZ0ZSwNLqab4Y2OcoXbUNkJzRXiwgvqAdXAiXcu5ZF2+vgaxgbqUie63iiF2QO nfH099ECKwjgMmRjT56M/6/kOKJMKy9uynecwuvuxPLr2aohyVr/BBqLr3upMvm1b1 dnwLTeUsbZnKdabzqMEB9aPoGHWsiF/JaNO0Paq4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726321AbgKFHXY (ORCPT ); Fri, 6 Nov 2020 02:23:24 -0500 Received: from mail.kernel.org ([198.145.29.99]:45638 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725828AbgKFHXY (ORCPT ); Fri, 6 Nov 2020 02:23:24 -0500 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E346F20825; Fri, 6 Nov 2020 07:23:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604647403; bh=bZJj9WzPD8oFm2s1+akaeCuY5a6U01z3MrdDbjK8/Wg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SIcEk99OJ4VFTbYW0yjOffgikbLeXsA+wGZwFN+Y8mCjh7EPIIibbGa5bK+p5Y+iJ TjCrMctji9tbz6sdmeR5D90XVG7CS0wFRHlQetPCM1jPQhgEWoavBDWYwCqzTL/UoQ /NLE8cZ86XvPHeVG7xAcrlFVIjVfRPKuzGMjSC9g= Date: Fri, 6 Nov 2020 08:24:10 +0100 From: Greg Kroah-Hartman To: Saravana Kannan Cc: "Rafael J. Wysocki" , "Rafael J. Wysocki" , Len Brown , Ard Biesheuvel , Rob Herring , Frank Rowand , Marc Zyngier , Thomas Gleixner , Tomi Valkeinen , Laurent Pinchart , Grygorii Strashko , Android Kernel Team , ACPI Devel Maling List , LKML , linux-efi , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" Subject: Re: [PATCH v1 17/18] driver core: Add helper functions to convert fwnode links to device links Message-ID: <20201106072410.GC2614221@kroah.com> References: <20201104232356.4038506-1-saravanak@google.com> <20201104232356.4038506-18-saravanak@google.com> <20201105094350.GG3439341@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Thu, Nov 05, 2020 at 03:32:05PM -0800, Saravana Kannan wrote: > On Thu, Nov 5, 2020 at 1:43 AM Greg Kroah-Hartman > wrote: > > > > On Wed, Nov 04, 2020 at 03:23:54PM -0800, Saravana Kannan wrote: > > > Add helper functions __fw_devlink_link_to_consumers() and > > > __fw_devlink_link_to_suppliers() that convert fwnode links to device > > > links. > > > > > > __fw_devlink_link_to_consumers() is for creating: > > > - Device links between a newly added device and all its consumer devices > > > that have been added to driver core. > > > - Proxy SYNC_STATE_ONLY device links between the newly added device and > > > the parent devices of all its consumers that have not been added to > > > driver core yet. > > > > > > __fw_devlink_link_to_suppliers() is for creating: > > > - Device links between a newly added device and all its supplier devices > > > - Proxy SYNC_STATE_ONLY device links between the newly added device and > > > all the supplier devices of its child device nodes. > > > > > > Signed-off-by: Saravana Kannan > > > > Did you just add build warnings with these static functions that no one > > calls? > > The next patch in this series uses it. I'm just splitting it up into a > separate patch so that it's digestible and I can provide more details > in the commit text. But you can not add build warnings, you know this :) > Couple of options: > 1. Drop the static in this patch and add it back when it's used in patch 18/18. > 2. Drop the commit text and squash this with 18/18 if you think the > function documentation is clear enough and it won't make patch 18/18 > too hard to review. It is hard to review new functions when you do not see them being used, otherwise you have to flip back and forth between patches, which is difficult. Add the functions, and use them, in the same patch. Otherwise we have no idea _HOW_ you are using them, or even if you end up using them at all. thanks, greg k-h