Re: [PATCH v1 2/3] rtc: ds1307: Make use of device properties

Andy Shevchenko
2020-11-12T16:25:51Z

On Thu, Nov 12, 2020 at 05:57:52PM +0200, Andy Shevchenko wrote:
> Device property API allows to gather device resources from different sources,
> such as ACPI. Convert the drivers to unleash the power of device property API.

> + const char *ds3231_clks_names[] = {
> + [DS3231_CLK_SQW] = ds3231_clks_init[DS3231_CLK_SQW].name,
> + [DS3231_CLK_32KHZ] = ds3231_clks_init[DS3231_CLK_32KHZ].name,
> + };

I realised I can do this slightly better, i.e. drop the names from the struct
and move them here while declaring latter as static and moving outside of the
function.

In any case I'll wait for comments for the rest and this patch before updating.

--
With Best Regards,
Andy Shevchenko