From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
linux-rtc@vger.kernel.org, Tin Huynh <tnhuynh@apm.com>,
linux-acpi@vger.kernel.org
Subject: Re: [PATCH v1 2/3] rtc: ds1307: Make use of device properties
Date: Thu, 12 Nov 2020 18:26:47 +0200 [thread overview]
Message-ID: <20201112162647.GI4077@smile.fi.intel.com> (raw)
In-Reply-To: <20201112155753.36834-2-andriy.shevchenko@linux.intel.com>
On Thu, Nov 12, 2020 at 05:57:52PM +0200, Andy Shevchenko wrote:
> Device property API allows to gather device resources from different sources,
> such as ACPI. Convert the drivers to unleash the power of device property API.
> + const char *ds3231_clks_names[] = {
> + [DS3231_CLK_SQW] = ds3231_clks_init[DS3231_CLK_SQW].name,
> + [DS3231_CLK_32KHZ] = ds3231_clks_init[DS3231_CLK_32KHZ].name,
> + };
I realised I can do this slightly better, i.e. drop the names from the struct
and move them here while declaring latter as static and moving outside of the
function.
In any case I'll wait for comments for the rest and this patch before updating.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-11-12 16:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-12 15:57 [PATCH v1 1/3] rtc: ds1307: Remove non-valid ACPI IDs Andy Shevchenko
2020-11-12 15:57 ` [PATCH v1 2/3] rtc: ds1307: Make use of device properties Andy Shevchenko
2020-11-12 16:26 ` Andy Shevchenko [this message]
2020-11-12 15:57 ` [PATCH v1 3/3] rtc: ds1307: Drop of_match_ptr and CONFIG_OF protections Andy Shevchenko
2020-11-12 16:36 ` [PATCH v1 1/3] rtc: ds1307: Remove non-valid ACPI IDs Alexandre Belloni
2020-11-12 17:16 ` Andy Shevchenko
2020-11-12 19:01 ` Rafael J. Wysocki
2020-11-13 14:11 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201112162647.GI4077@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=tnhuynh@apm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox