Re: [PATCH v1 1/3] rtc: ds1307: Remove non-valid ACPI IDs

Andy Shevchenko
2020-11-13T14:10:38Z

On Thu, Nov 12, 2020 at 08:01:37PM +0100, Rafael J. Wysocki wrote:
> On Thu, Nov 12, 2020 at 4:58 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> >
> > The commit 9c19b8930d2c ("rtc: ds1307: Add ACPI support") added non-valid
>
> s/non-valid/invalid/ ?
>
> > ACPI IDs (all of them abusing ACPI specification). Moreover there is
> > no even a single evidence that vendor registered any of such device.
>
> "not even" and "devices".
>
> > Remove broken ACPI IDs from the driver. For prototyping one may use PRP0001
> > with device tree defined bindings.
>
> "with device properties adhering to a DT binding". ?
>
> > The following patches will add support of that to the driver.

Rafael, thanks for review, I will address them all in v2.

--
With Best Regards,
Andy Shevchenko