Re: [RFC PATCH 3/9] cxl/mem: Add a driver for the type-3 mailbox

Christoph Hellwig
2020-11-11T07:22:22Z

On Tue, Nov 10, 2020 at 09:43:50PM -0800, Ben Widawsky wrote:
> +config CXL_MEM
> + tristate "CXL.mem Device Support"
> + depends on PCI && CXL_BUS_PROVIDER != n

depend on PCI && CXL_BUS_PROVIDER

> + default m if CXL_BUS_PROVIDER

Please don't set weird defaults for new code. Especially not default
to module crap like this.

> +// Copyright(c) 2020 Intel Corporation. All rights reserved.

Please don't use '//' for anything but the SPDX header.

> +
> + pci_read_config_word(pdev, pos + PCI_DVSEC_VENDOR_OFFSET, &vendor);
> + pci_read_config_word(pdev, pos + PCI_DVSEC_ID_OFFSET, &id);
> + if (vendor == PCI_DVSEC_VENDOR_CXL && dvsec == id)
> + return pos;
> +
> + pos = pci_find_next_ext_capability(pdev, pos, PCI_EXT_CAP_ID_DVSEC);

Overly long lines again.

> +static void cxl_mem_remove(struct pci_dev *pdev)
> +{
> +}

No need for the empty remove callback.

> +MODULE_AUTHOR("Intel Corporation");

A module author is not a company.