* [PATCH] ACPI: processor: Drop duplicate setting of shared_cpu_map
@ 2020-11-23 23:59 Punit Agrawal
2020-11-25 15:47 ` Rafael J. Wysocki
0 siblings, 1 reply; 2+ messages in thread
From: Punit Agrawal @ 2020-11-23 23:59 UTC (permalink / raw)
To: rjw; +Cc: lenb, linux-acpi, linux-kernel, Punit Agrawal
'shared_cpu_map', stored as part of the per-processor
acpi_processor_performance structre, is used to store cpus that share
a performance domain. By definition it contains the owning cpu.
While building the 'shared_cpu_map' it is being set twice - once while
initialising the performance domains and again when matching cpus
belonging to the same domain.
Drop the unnecessary initialisation.
Signed-off-by: Punit Agrawal <punitagrawal@gmail.com>
---
drivers/acpi/processor_perflib.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/acpi/processor_perflib.c b/drivers/acpi/processor_perflib.c
index b04a68950ff1..b0d320f18163 100644
--- a/drivers/acpi/processor_perflib.c
+++ b/drivers/acpi/processor_perflib.c
@@ -616,7 +616,6 @@ int acpi_processor_preregister_performance(
continue;
pr->performance = per_cpu_ptr(performance, i);
- cpumask_set_cpu(i, pr->performance->shared_cpu_map);
pdomain = &(pr->performance->domain_info);
if (acpi_processor_get_psd(pr->handle, pdomain)) {
retval = -EINVAL;
--
2.29.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] ACPI: processor: Drop duplicate setting of shared_cpu_map
2020-11-23 23:59 [PATCH] ACPI: processor: Drop duplicate setting of shared_cpu_map Punit Agrawal
@ 2020-11-25 15:47 ` Rafael J. Wysocki
0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2020-11-25 15:47 UTC (permalink / raw)
To: Punit Agrawal
Cc: Rafael J. Wysocki, Len Brown, ACPI Devel Maling List,
Linux Kernel Mailing List
On Tue, Nov 24, 2020 at 1:00 AM Punit Agrawal <punitagrawal@gmail.com> wrote:
>
> 'shared_cpu_map', stored as part of the per-processor
> acpi_processor_performance structre, is used to store cpus that share
> a performance domain. By definition it contains the owning cpu.
>
> While building the 'shared_cpu_map' it is being set twice - once while
> initialising the performance domains and again when matching cpus
> belonging to the same domain.
>
> Drop the unnecessary initialisation.
>
> Signed-off-by: Punit Agrawal <punitagrawal@gmail.com>
> ---
> drivers/acpi/processor_perflib.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/acpi/processor_perflib.c b/drivers/acpi/processor_perflib.c
> index b04a68950ff1..b0d320f18163 100644
> --- a/drivers/acpi/processor_perflib.c
> +++ b/drivers/acpi/processor_perflib.c
> @@ -616,7 +616,6 @@ int acpi_processor_preregister_performance(
> continue;
>
> pr->performance = per_cpu_ptr(performance, i);
> - cpumask_set_cpu(i, pr->performance->shared_cpu_map);
> pdomain = &(pr->performance->domain_info);
> if (acpi_processor_get_psd(pr->handle, pdomain)) {
> retval = -EINVAL;
> --
Applied as 5.11 material, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-25 15:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-23 23:59 [PATCH] ACPI: processor: Drop duplicate setting of shared_cpu_map Punit Agrawal
2020-11-25 15:47 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox