From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1A63C64E8A for ; Mon, 30 Nov 2020 19:20:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 753F920789 for ; Mon, 30 Nov 2020 19:20:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729882AbgK3TTv (ORCPT ); Mon, 30 Nov 2020 14:19:51 -0500 Received: from mga07.intel.com ([134.134.136.100]:24379 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729847AbgK3TTp (ORCPT ); Mon, 30 Nov 2020 14:19:45 -0500 IronPort-SDR: Fvd7MtfMuH1xRYF29/klr+iS0DEaXhYhUVTwWWAq4GY7YcFQFt8TX1oepVSHmDxPXae8UfkaI+ 26rXe0NKlj+Q== X-IronPort-AV: E=McAfee;i="6000,8403,9821"; a="236821998" X-IronPort-AV: E=Sophos;i="5.78,382,1599548400"; d="scan'208";a="236821998" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Nov 2020 11:18:03 -0800 IronPort-SDR: RTneXUqRmmUUB51Riy9ytU0vo0Iy8zp5GSqpWWuNwreaTGW9K1dMSqlnr1+2fIdmguqifaiTnv IXsetQfd35Gg== X-IronPort-AV: E=Sophos;i="5.78,382,1599548400"; d="scan'208";a="345185764" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Nov 2020 11:17:56 -0800 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1kjohM-00B74y-Qp; Mon, 30 Nov 2020 21:18:56 +0200 Date: Mon, 30 Nov 2020 21:18:56 +0200 From: Andy Shevchenko To: Laurent Pinchart Cc: Daniel Scally , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-gpio@vger.kernel.org, linux-i2c@vger.kernel.org, linux-media@vger.kernel.org, devel@acpica.org, rjw@rjwysocki.net, lenb@kernel.org, gregkh@linuxfoundation.org, mika.westerberg@linux.intel.com, linus.walleij@linaro.org, bgolaszewski@baylibre.com, wsa@kernel.org, yong.zhi@intel.com, sakari.ailus@linux.intel.com, bingbu.cao@intel.com, tian.shu.qiu@intel.com, mchehab@kernel.org, robert.moore@intel.com, erik.kaneda@intel.com, pmladek@suse.com, rostedt@goodmis.org, sergey.senozhatsky@gmail.com, linux@rasmusvillemoes.dk, kieran.bingham+renesas@ideasonboard.com, jacopo+renesas@jmondi.org, laurent.pinchart+renesas@ideasonboard.com, jorhand@linux.microsoft.com, kitakar@gmail.com, heikki.krogerus@linux.intel.com Subject: Re: [PATCH 16/18] i2c: i2c-core-base: Use the new i2c_acpi_dev_name() in i2c_set_dev_name() Message-ID: <20201130191856.GX4077@smile.fi.intel.com> References: <20201130133129.1024662-1-djrscally@gmail.com> <20201130133129.1024662-17-djrscally@gmail.com> <20201130171241.GP14465@pendragon.ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201130171241.GP14465@pendragon.ideasonboard.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Mon, Nov 30, 2020 at 07:12:41PM +0200, Laurent Pinchart wrote: > On Mon, Nov 30, 2020 at 01:31:27PM +0000, Daniel Scally wrote: > > From: Dan Scally > > > > To make sure the new i2c_acpi_dev_name() always reflects the name of i2c > > devices sourced from ACPI, use it in i2c_set_dev_name(). > > > > Signed-off-by: Dan Scally > > I'd squash this with 15/18, which would make it clear there's a memory > leak :-) ... > > if (adev) { > > - dev_set_name(&client->dev, "i2c-%s", acpi_dev_name(adev)); > > + dev_set_name(&client->dev, i2c_acpi_dev_name(adev)); > > return; But you split pattern used in i2c_dev_set_name(). What you need is to provide something like this #define I2C_DEV_NAME_FORMAT "i2c-%s" const char *i2c_acpi_get_dev_name(...) { return kasprintf(..., I2C_DEV_NAME_FORMAT, ...); } (Possible in the future if anybody needs const char *i2c_dev_get_name_by_bus_and_addr(int bus, unsigned short addr) ) And here - dev_set_name(&client->dev, "i2c-%s", info->dev_name); + dev_set_name(&client->dev, I2C_DEV_NAME_FORMAT, info->dev_name); - dev_set_name(&client->dev, "i2c-%s", acpi_dev_name(adev)); + dev_set_name(&client->dev, I2C_DEV_NAME_FORMAT, acpi_dev_name(adev)); -- With Best Regards, Andy Shevchenko;