From: Mian Yousaf Kaukab <ykaukab@suse.de>
To: Ionela Voinescu <ionela.voinescu@arm.com>
Cc: rjw@rjwysocki.net, viresh.kumar@linaro.org, lenb@kernel.org,
yousaf.kaukab@suse.com, jeremy.linton@arm.com,
lukasz.luba@arm.com, valentin.schneider@arm.com,
linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/4] cppc_cpufreq: fix, clarify and improve support
Date: Mon, 14 Dec 2020 17:11:58 +0100 [thread overview]
Message-ID: <20201214161158.GA11066@suse.de> (raw)
In-Reply-To: <20201214123823.3949-1-ionela.voinescu@arm.com>
On Mon, Dec 14, 2020 at 12:38:19PM +0000, Ionela Voinescu wrote:
> Hi guys,
>
> I'm sending v2 of some of the patches at [1] in light of the discussions
> at [2].
>
> v2:
> - Patches 1-3 are trivial rebase on linux next 20201211, with conflicts
> fixed after eliminating what previously was "[PATCH 4/8] cppc_cpufreq:
> replace per-cpu structures with lists." Therefore, I have kept
> Viresh's acks.
>
> - Patch 4 is a merge between:
> - [PATCH 4/8] cppc_cpufreq: replace per-cpu structures with lists
> - [PATCH] cppc_cpufreq: optimise memory allocation for HW and NONE
> coordination
> both found at [1].
>
> This functionality was introducing the problem at [2] and it's fixed
> in this version by bailing out of driver registration if a _CPC entry
> is not found for a CPU.
>
> Yousaf, it would be great if you can test this and make sure it
> matches your expectations.
>
> Rafael, Viresh if you think this last patch introduces too many
> changes, you can skip it for 5.11 which is around the corner and
> have more time for review for 5.12. I've added more eyes in the review
> list.
>
>
> All patches are based on linux next 20201211 after patch at [3] is
> applied.
>
> [1] https://lore.kernel.org/linux-pm/20201105125524.4409-1-ionela.voinescu@arm.com/#t
> [2] https://lore.kernel.org/linux-pm/20201210142139.20490-1-yousaf.kaukab@suse.com/
> [3] https://lore.kernel.org/linux-pm/20201214120740.10948-1-ionela.voinescu@arm.com/
>
> Ionela Voinescu (4):
> cppc_cpufreq: use policy->cpu as driver of frequency setting
> cppc_cpufreq: clarify support for coordination types
> cppc_cpufreq: expose information on frequency domains
> cppc_cpufreq: replace per-cpu data array with a list
>
> .../ABI/testing/sysfs-devices-system-cpu | 3 +-
> drivers/acpi/cppc_acpi.c | 141 ++++++------
> drivers/cpufreq/cppc_cpufreq.c | 204 ++++++++++--------
> include/acpi/cppc_acpi.h | 6 +-
> 4 files changed, 181 insertions(+), 173 deletions(-)
For the whole series:
Tested-by: Mian Yousaf Kaukab <ykaukab@suse.de>
next prev parent reply other threads:[~2020-12-14 16:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-14 12:38 [PATCH v2 0/4] cppc_cpufreq: fix, clarify and improve support Ionela Voinescu
2020-12-14 12:38 ` [PATCH v2 1/4] cppc_cpufreq: use policy->cpu as driver of frequency setting Ionela Voinescu
2020-12-14 12:38 ` [PATCH v2 2/4] cppc_cpufreq: clarify support for coordination types Ionela Voinescu
2020-12-14 12:38 ` [PATCH v2 3/4] cppc_cpufreq: expose information on frequency domains Ionela Voinescu
2020-12-14 12:38 ` [PATCH v2 4/4] cppc_cpufreq: replace per-cpu data array with a list Ionela Voinescu
2020-12-14 16:11 ` Mian Yousaf Kaukab [this message]
2020-12-15 18:21 ` [PATCH v2 0/4] cppc_cpufreq: fix, clarify and improve support Rafael J. Wysocki
2020-12-15 23:31 ` Ionela Voinescu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201214161158.GA11066@suse.de \
--to=ykaukab@suse.de \
--cc=ionela.voinescu@arm.com \
--cc=jeremy.linton@arm.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=rjw@rjwysocki.net \
--cc=valentin.schneider@arm.com \
--cc=viresh.kumar@linaro.org \
--cc=yousaf.kaukab@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).