From: Guenter Roeck <linux@roeck-us.net>
To: Erik Kaneda <erik.kaneda@intel.com>
Cc: "Rafael J . Wysocki" <rafael@kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Robert Moore <robert.moore@intel.com>,
Jon Hunter <jonathanh@nvidia.com>
Subject: Re: [v2,3/9] ACPICA: ACPICA: fix -Wfallthrough
Date: Sat, 23 Jan 2021 07:25:20 -0800 [thread overview]
Message-ID: <20210123152520.GA41373@roeck-us.net> (raw)
In-Reply-To: <20210123152104.GA36465@roeck-us.net>
On Sat, Jan 23, 2021 at 07:21:04AM -0800, Guenter Roeck wrote:
> On Thu, Jan 21, 2021 at 04:23:51PM -0800, Erik Kaneda wrote:
> > From: Nick Desaulniers <ndesaulniers@google.com>
> >
> > ACPICA commit 4b9135f5774caa796ddf826448811e8e7f08ef2f
> >
> > GCC 7.1 gained -Wimplicit-fallthrough to warn on implicit fallthrough,
> > as well as __attribute__((__fallthrough__)) and comments to explicitly
> > denote that cases of fallthrough were intentional. Clang also supports
> > this warning and statement attribute, but not the comment form.
> >
> > Robert Moore provides additional context about the lint comments being
> > removed. They were for "an old version of PC-Lint, which we don't use
> > anymore." Drop those.
> >
> > This will help us enable -Wimplicit-fallthrough throughout the Linux
> > kernel.
> >
> > Suggested-by: Robert Moore <robert.moore@intel.com>
> > Reported-by: Jon Hunter <jonathanh@nvidia.com>
> >
> > Link: https://github.com/acpica/acpica/commit/4b9135f5
> > Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
> > Signed-off-by: Bob Moore <robert.moore@intel.com>
> > Signed-off-by: Erik Kaneda <erik.kaneda@intel.com>
>
> With gcc 6.5 (and presumably each gcc version older than 7.1),
> this patch results in:
>
> drivers/acpi/acpica/dscontrol.c: In function ‘acpi_ds_exec_begin_control_op’:
> drivers/acpi/acpica/dscontrol.c:65:3: error: ‘ACPI_FALLTHROUGH’ undeclared
>
> and similar errors for other files.
>
Wait, this differs from the patch in -next.
> > +#ifndef ACPI_FALLTHROUGH
> > +#define ACPI_FALLTHROUGH do {} while(0)
This line is missing in -next.
v2 doesn't say what changed in v2. Is that the change ?
Guenter
next prev parent reply other threads:[~2021-01-23 15:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-22 0:23 [PATCH v2 0/9] ACPICA release 20201217 and 20210105 Erik Kaneda
2021-01-22 0:23 ` [PATCH v2 1/9] ACPICA: Fix exception code class checks Erik Kaneda
2021-01-22 0:23 ` [PATCH v2 2/9] ACPICA: Clean up " Erik Kaneda
2021-01-22 0:23 ` [PATCH v2 3/9] ACPICA: ACPICA: fix -Wfallthrough Erik Kaneda
2021-01-23 15:21 ` [v2,3/9] " Guenter Roeck
2021-01-23 15:25 ` Guenter Roeck [this message]
2021-01-23 20:11 ` Rafael J. Wysocki
2021-01-22 0:23 ` [PATCH v2 4/9] ACPICA: add type casts for string functions Erik Kaneda
2021-01-22 0:23 ` [PATCH v2 5/9] ACPICA: Update version to 20201217 Version 20201217 Erik Kaneda
2021-01-22 0:23 ` [PATCH v2 6/9] ACPICA: Remove the MTMR (Mid-Timer) table Erik Kaneda
2021-01-22 0:23 ` [PATCH v2 7/9] ACPICA: Remove the VRTC table Erik Kaneda
2021-01-22 0:23 ` [PATCH v2 8/9] ACPICA: Updated all copyrights to 2021 Erik Kaneda
2021-01-22 0:23 ` [PATCH v2 9/9] ACPICA: Update version to 20210105 Erik Kaneda
2021-01-22 15:07 ` [PATCH v2 0/9] ACPICA release 20201217 and 20210105 Rafael J. Wysocki
2021-01-22 17:57 ` Kaneda, Erik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210123152520.GA41373@roeck-us.net \
--to=linux@roeck-us.net \
--cc=erik.kaneda@intel.com \
--cc=jonathanh@nvidia.com \
--cc=linux-acpi@vger.kernel.org \
--cc=ndesaulniers@google.com \
--cc=rafael@kernel.org \
--cc=robert.moore@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).