From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51D9CC433DB for ; Wed, 27 Jan 2021 12:55:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0357C207A2 for ; Wed, 27 Jan 2021 12:55:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237943AbhA0Mzb (ORCPT ); Wed, 27 Jan 2021 07:55:31 -0500 Received: from mga11.intel.com ([192.55.52.93]:48650 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238066AbhA0Mwi (ORCPT ); Wed, 27 Jan 2021 07:52:38 -0500 IronPort-SDR: CZB6JRl299cKdDBLVezpuoH95l8KaZPXMy87ZusmDfMXf820Ge0MaFAB1rT8XSbayo3MVNU7Oq /HEOEehY/jnQ== X-IronPort-AV: E=McAfee;i="6000,8403,9876"; a="176551754" X-IronPort-AV: E=Sophos;i="5.79,379,1602572400"; d="scan'208";a="176551754" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jan 2021 04:49:44 -0800 IronPort-SDR: NJDK9KRqBG61tdPn3HyFnSon9wtk2ujx9vVoCAGI5VRYIYZ7c7AZDO6Raw4eqkCxGCsEMa8N96 97IuSuPBu5Tg== X-IronPort-AV: E=Sophos;i="5.79,379,1602572400"; d="scan'208";a="362420090" Received: from lahna.fi.intel.com (HELO lahna) ([10.237.72.163]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jan 2021 04:49:38 -0800 Received: by lahna (sSMTP sendmail emulation); Wed, 27 Jan 2021 14:49:35 +0200 Date: Wed, 27 Jan 2021 14:49:35 +0200 From: Mika Westerberg To: "Limonciello, Mario" Cc: "Rafael J. Wysocki" , "open list:ULTRA-WIDEBAND (UWB) SUBSYSTEM:" , Michael Jamet , Yehezkel Bernat , Andreas Noever , Lukas Wunner , "Rafael J. Wysocki" , Christian Kellner , Len Brown , Greg Kroah-Hartman , ACPI Devel Maling List Subject: Re: [PATCH 4/6] ACPI: Execute platform _OSC also with query bit clear Message-ID: <20210127124935.GC2542@lahna.fi.intel.com> References: <20210126155723.9388-1-mika.westerberg@linux.intel.com> <20210126155723.9388-5-mika.westerberg@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Tue, Jan 26, 2021 at 10:43:32PM +0000, Limonciello, Mario wrote: > > I would put that information into the changelog. > > Thanks, @Mika Westerberg can you collapse that in when you re-spin the > series? Sure. > > > > Moreover, have you looked at acpi_pci_osc_control_set()? > > > > What it does is analogous to what you are proposing, but a bit > > different, and I would like to preserve consistency between _OSC use > > cases. > > > > So would it be possible to adjust the _SB _OSC evaluation flow to > > follow the PCI _OSC one? That is, if any control bits are there, pass > > them along with the last evaluation of _OSC with the query flag clear. > > Or is the latter defective and if so then why? > > Basically the only difference is another line cloning OSC_CONTROL_DWORD from > capbuf_ret to capbuf? > > Yes, this actually sounds like it better adheres to the spec to me. > > Quoting spec: > " If the OS is granted control of a feature in the Control Field in one call to > _OSC, then it must preserve the set state of that bit (requesting that feature) > in all subsequent calls." However, the platform wide _OSC does not actually have this OSC_CONTROL_DWORD at all ;-) I think what we do in this patch is already equivalent to what the PCI _OSC is doing: 1. Query bit set _OSC 2. Take the returned OSC_SUPPORT_DWORD buffer and 3. Pass it to the _OSC with query bit clear. I may be missing something, though.