From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38303C433DB for ; Sat, 6 Feb 2021 10:49:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F19C064E40 for ; Sat, 6 Feb 2021 10:49:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229541AbhBFKtn (ORCPT ); Sat, 6 Feb 2021 05:49:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59290 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229507AbhBFKtm (ORCPT ); Sat, 6 Feb 2021 05:49:42 -0500 Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [IPv6:2607:f8b0:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 118DBC06174A for ; Sat, 6 Feb 2021 02:49:02 -0800 (PST) Received: by mail-pl1-x635.google.com with SMTP id k22so509607pll.6 for ; Sat, 06 Feb 2021 02:49:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Wnt31go3qxgTOGvZP7DEXg16m0fpmuqivDt/iA9WlXo=; b=X5HqkrqQuQZWnnV3phuwbdLjM4fwAzOSaxUHw/etu7wLv1QYGARa2rNZFZoZbKSTDO a3uFqOptwDHzZtSVGFG9tLzsDhOm1FjgypGVBjHlBIfJvNYzpYDl0McPhlmwdwqMB+2P CmkRk3fMVp+ojccORatFQlrHEKqrpr3xcUr/nXiQPgJ2zAtSXNV1B3U1JZUv2YoJ082R mWSARARH1RdRszQcmUwdYwCMqs9Wiahw+JdwV//p12gCGhT3zGAAmvdpE8Ax8qu9oJiv v7RltzY3f0CnFkzuzaOXfd7649nYCMqmj8aHsgzdnsoa+HpsnfUuiTth39Vg/SG44NUC 7rJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Wnt31go3qxgTOGvZP7DEXg16m0fpmuqivDt/iA9WlXo=; b=TEOAis00ObRjK1C61B0G4tLVpBeO//qhS7pfZ0Jl+prAePA7+JZ0YV5pupcvK5dAwN HmvGAMLsdd+at4crkCIkMbYgfRGXBmdxmQmMKWMcHnxfWlpznTKAY3YUx927lbVGnoUE 1VW4El5KvuJVoSR87NhqQR3Lu9vUvdbZILTeyTGrzhjoIXoqJ3p6WcgSBGC0Tabyrmy7 HiPlULTWodSiQmmYiO5C2W1X6Z6coBmf8W3gTjWU8rdO/NxDcqW98G9Nmczt9G7yNzhD sQyGgPVmggxg4Nwttyufxrv3wxMpmsc8Rx12nh2tOz9lRh5hg3G0LV2EVInNsSwSFQub qxJg== X-Gm-Message-State: AOAM5319DcrB3kttMLB1PVoigvrx8l0MyOM9JSDxysK9lVbTXpScMgi8 r7ovpJHc0JiFH82EJxz98jsANI9SxChj5w== X-Google-Smtp-Source: ABdhPJzRpTiDsbSCcJBW5kdLUgEacWK8AWdgcA9tGT89CZK6du++rz58bXp0VU+OaB8ILLcj0PYzXA== X-Received: by 2002:a17:90a:318d:: with SMTP id j13mr8103093pjb.77.1612608541526; Sat, 06 Feb 2021 02:49:01 -0800 (PST) Received: from dragon (80.251.214.228.16clouds.com. [80.251.214.228]) by smtp.gmail.com with ESMTPSA id j9sm10635936pjn.32.2021.02.06.02.48.59 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 06 Feb 2021 02:49:01 -0800 (PST) Date: Sat, 6 Feb 2021 18:48:55 +0800 From: Shawn Guo To: Ard Biesheuvel Cc: linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, devel@acpica.org, Robert Moore , Erik Kaneda , "Rafael J. Wysocki" , Len Brown Subject: Re: [PATCH] Revert "ACPICA: Interpreter: fix memory leak by using existing buffer" Message-ID: <20210206104854.GC27503@dragon> References: <20210206084937.20853-1-ardb@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210206084937.20853-1-ardb@kernel.org> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Sat, Feb 06, 2021 at 09:49:37AM +0100, Ard Biesheuvel wrote: > This reverts commit 32cf1a12cad43358e47dac8014379c2f33dfbed4. > > The 'exisitng buffer' in this case is the firmware provided table, and > we should not modify that in place. This fixes a crash on arm64 with > initrd table overrides, in which case the DSDT is not mapped with > read/write permissions. > > Cc: Robert Moore > Cc: Erik Kaneda > Cc: "Rafael J. Wysocki" > Cc: Len Brown > Reported-by: Shawn Guo > Signed-off-by: Ard Biesheuvel Tested-by: Shawn Guo Thanks for fixing the regression, Ard! Shawn