From: "Marcin Ślusarz" <marcin.slusarz@gmail.com>
To: alsa-devel@alsa-project.org, linux-acpi@vger.kernel.org
Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Salvatore Bonaccorso <carnil@debian.org>,
marcin.slusarz@intel.com
Subject: [PATCH 2/2] ACPICA: update documentation of acpi_walk_namespace
Date: Mon, 8 Feb 2021 13:01:04 +0100 [thread overview]
Message-ID: <20210208120104.204761-2-marcin.slusarz@gmail.com> (raw)
In-Reply-To: <20210208120104.204761-1-marcin.slusarz@gmail.com>
From: Marcin Ślusarz <marcin.slusarz@intel.com>
Signed-off-by: Marcin Ślusarz <marcin.slusarz@intel.com>
---
drivers/acpi/acpica/nsxfeval.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/acpi/acpica/nsxfeval.c b/drivers/acpi/acpica/nsxfeval.c
index f9d059647cc5..7149c8f70a6e 100644
--- a/drivers/acpi/acpica/nsxfeval.c
+++ b/drivers/acpi/acpica/nsxfeval.c
@@ -532,8 +532,8 @@ static void acpi_ns_resolve_references(struct acpi_evaluate_info *info)
* return_value - Location where return value of
* user_function is put if terminated early
*
- * RETURNS Return value from the user_function if terminated early.
- * Otherwise, returns NULL.
+ * RETURNS Returns status from the callback function if terminated early.
+ * Otherwise, returns a status of the walk, AE_OK if succeeded.
*
* DESCRIPTION: Performs a modified depth-first walk of the namespace tree,
* starting (and ending) at the object specified by start_handle.
@@ -542,6 +542,11 @@ static void acpi_ns_resolve_references(struct acpi_evaluate_info *info)
* a non-zero value, the search is terminated immediately and this
* value is returned to the caller.
*
+ * Note that both the callback functions and the walk itself
+ * use overlapping return values (e.g. AE_OK), so user of this
+ * function can't rely only on the return value to tell if
+ * the callback function was called.
+ *
* The point of this procedure is to provide a generic namespace
* walk routine that can be called from multiple places to
* provide multiple services; the callback function(s) can be
--
2.25.1
next prev parent reply other threads:[~2021-02-08 12:04 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-20 19:56 Crash in acpi_ns_validate_handle triggered by soundwire on Linux 5.10 Marcin Ślusarz
2021-01-20 20:34 ` Rafael J. Wysocki
2021-01-20 22:28 ` Pierre-Louis Bossart
2021-01-21 17:47 ` Marcin Ślusarz
2021-01-27 16:36 ` Marcin Ślusarz
2021-01-27 17:28 ` Pierre-Louis Bossart
2021-01-27 19:18 ` Marcin Ślusarz
2021-01-27 21:52 ` Pierre-Louis Bossart
2021-01-27 22:02 ` Pierre-Louis Bossart
2021-01-28 13:25 ` Marcin Ślusarz
2021-01-28 13:31 ` Rafael J. Wysocki
2021-01-28 12:13 ` Rafael J. Wysocki
2021-01-28 12:39 ` Rafael J. Wysocki
2021-01-28 13:45 ` Marcin Ślusarz
2021-01-28 14:32 ` Marcin Ślusarz
2021-01-29 18:59 ` Marcin Ślusarz
2021-01-29 20:03 ` Marcin Ślusarz
2021-02-01 11:42 ` Rafael J. Wysocki
2021-02-01 12:16 ` Marcin Ślusarz
2021-02-04 12:11 ` Marcin Ślusarz
2021-02-04 12:48 ` Marcin Ślusarz
2021-02-05 15:40 ` [PATCH] soundwire: intel: fix possible crash when no device is detected (was Re: Crash in acpi_ns_validate_handle triggered by soundwire on Linux 5.10) Marcin Ślusarz
2021-02-05 16:16 ` Pierre-Louis Bossart
2021-02-08 12:01 ` [PATCH 1/2] soundwire: intel: fix possible crash when no device is detected Marcin Ślusarz
2021-02-08 12:01 ` Marcin Ślusarz [this message]
2021-02-08 12:43 ` [PATCH 2/2] ACPICA: update documentation of acpi_walk_namespace Rafael J. Wysocki
2021-02-12 12:27 ` [PATCH] " Marcin Ślusarz
2021-02-12 13:26 ` Rafael J. Wysocki
2021-02-08 12:37 ` [PATCH 1/2] soundwire: intel: fix possible crash when no device is detected Rafael J. Wysocki
2021-02-10 23:15 ` Pierre-Louis Bossart
2021-02-11 5:20 ` Vinod Koul
2021-01-28 13:29 ` Crash in acpi_ns_validate_handle triggered by soundwire on Linux 5.10 Marcin Ślusarz
2021-01-28 13:36 ` Rafael J. Wysocki
2021-01-25 18:38 ` Salvatore Bonaccorso
2021-01-25 19:26 ` Pierre-Louis Bossart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210208120104.204761-2-marcin.slusarz@gmail.com \
--to=marcin.slusarz@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=carnil@debian.org \
--cc=linux-acpi@vger.kernel.org \
--cc=marcin.slusarz@intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox