From: Shawn Guo <shawn.guo@linaro.org>
To: Erik Kaneda <erik.kaneda@intel.com>
Cc: "Rafael J . Wysocki" <rafael@kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Gordon Ross <gordon.w.ross@gmail.com>,
Moore@dragon, Robert <robert.moore@intel.com>
Subject: Re: [RFT PATCH] ACPICA: Fix memory leak caused by _CID repair function
Date: Fri, 30 Apr 2021 21:22:04 +0800 [thread overview]
Message-ID: <20210430132203.GI15093@dragon> (raw)
In-Reply-To: <20210428225247.1701392-1-erik.kaneda@intel.com>
On Wed, Apr 28, 2021 at 03:52:47PM -0700, Erik Kaneda wrote:
> ACPICA commit 5fc4f4b87d6890d48d050ab279ed01f0132662ca
>
> According to the ACPI spec, _CID returns a package containing
> hardware ID's. Each element of an ASL package contains a reference
> count from the parent package as well as the element itself.
>
> Name (TEST, Package() {
> "String object" // this package element has a reference count of 2
> })
>
> A memory leak was caused in the _CID repair function because it did
> not decrement the reference count created by the package. Fix the
> memory leak by calling acpi_ut_remove_reference on _CID package elements
> that represent a hardware ID (_HID).
>
> Link: https://github.com/acpica/acpica/commit/5fc4f4b8
>
> Signed-off-by: Erik Kaneda <erik.kaneda@intel.com>
Tested on Snapdragon laptops, and nothing seems broken.
Tested-by: Shawn Guo <shawn.guo@linaro.org>
prev parent reply other threads:[~2021-04-30 13:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-28 22:52 [RFT PATCH] ACPICA: Fix memory leak caused by _CID repair function Erik Kaneda
2021-04-29 17:29 ` Kaneda, Erik
2021-04-30 13:22 ` Shawn Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210430132203.GI15093@dragon \
--to=shawn.guo@linaro.org \
--cc=Moore@dragon \
--cc=erik.kaneda@intel.com \
--cc=gordon.w.ross@gmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=robert.moore@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).