From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D036C433B4 for ; Fri, 14 May 2021 10:39:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0750361457 for ; Fri, 14 May 2021 10:39:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230168AbhENKka (ORCPT ); Fri, 14 May 2021 06:40:30 -0400 Received: from foss.arm.com ([217.140.110.172]:46978 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229964AbhENKka (ORCPT ); Fri, 14 May 2021 06:40:30 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BD8BF1713; Fri, 14 May 2021 03:39:18 -0700 (PDT) Received: from lpieralisi (e121166-lin.cambridge.arm.com [10.1.196.255]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4EFCD3F719; Fri, 14 May 2021 03:39:17 -0700 (PDT) Date: Fri, 14 May 2021 11:39:12 +0100 From: Lorenzo Pieralisi To: Heikki Krogerus Cc: Hanjun Guo , Sudeep Holla , "Rafael J. Wysocki" , Jean-Philippe Brucker , Joerg Roedel , Eric Auger , Will Deacon , linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ACPI/IORT: Handle device properties with software node API Message-ID: <20210514103912.GA16131@lpieralisi> References: <20210511125528.18525-1-heikki.krogerus@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210511125528.18525-1-heikki.krogerus@linux.intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Tue, May 11, 2021 at 03:55:28PM +0300, Heikki Krogerus wrote: > The older device property API is going to be removed. > Replacing the device_add_properties() call with software > node API equivalent device_create_managed_software_node(). > > Fixes: 434b73e61cc6 ("iommu/arm-smmu-v3: Use device properties for pasid-num-bits") Is this really fixing anything ? I am not sure I understand what you would like to achieve with this tag. > Signed-off-by: Heikki Krogerus > --- > drivers/acpi/arm64/iort.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) With the above comment clarified: Acked-by: Lorenzo Pieralisi > diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c > index 3912a1f6058e5..e34937e11186a 100644 > --- a/drivers/acpi/arm64/iort.c > +++ b/drivers/acpi/arm64/iort.c > @@ -976,7 +976,7 @@ static void iort_named_component_init(struct device *dev, > FIELD_GET(ACPI_IORT_NC_PASID_BITS, > nc->node_flags)); > > - if (device_add_properties(dev, props)) > + if (device_create_managed_software_node(dev, props, NULL)) > dev_warn(dev, "Could not add device properties\n"); > } > > -- > 2.30.2 >