From: Christoph Hellwig <hch@lst.de>
To: Mario Limonciello <mario.limonciello@amd.com>
Cc: Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@fb.com>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
"open list:NVM EXPRESS DRIVER" <linux-nvme@lists.infradead.org>,
linux-acpi@vger.kernel.org, rrangel@chromium.org,
david.e.box@linux.intel.com, Shyam-sundar.S-k@amd.com,
Alexander.Deucher@amd.com, prike.liang@amd.com,
Shyjumon N <shyjumon.n@intel.com>,
Jon Derrick <jonathan.derrick@intel.com>
Subject: Re: [PATCH v3 1/2] nvme: Look for StorageD3Enable on companion ACPI device instead
Date: Mon, 31 May 2021 08:46:55 +0200 [thread overview]
Message-ID: <20210531064655.GA1417@lst.de> (raw)
In-Reply-To: <20210528160234.9402-1-mario.limonciello@amd.com>
On Fri, May 28, 2021 at 11:02:34AM -0500, Mario Limonciello wrote:
> The documentation around the StorageD3Enable property hints that it
> should be made on the PCI device. This is where newer AMD systems set
> the property and it's required for S0i3 support.
>
> So rather than look for nodes of the root port only present on Intel
> systems, switch to the companion ACPI device for all systems.
> David Box from Intel indicated this should work on Intel as well.
I think we need to wait for the confirmation from David. This looks good,
but I'd like to see testing. I also wonder how many of the simple suspend
quirks we can drop with this.
Shyjumon and Jon, can you retests the platforms quirked in
1fae37accfc5 ("nvme/pci: Add sleep quirk for Samsung and Toshiba drives")
with this fix?
next prev parent reply other threads:[~2021-05-31 6:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-28 16:02 [PATCH v3 1/2] nvme: Look for StorageD3Enable on companion ACPI device instead Mario Limonciello
2021-05-31 6:46 ` Christoph Hellwig [this message]
2021-06-01 5:22 ` N, Shyjumon
2021-06-01 15:15 ` Limonciello, Mario
2021-06-02 22:49 ` David E. Box
2021-06-01 19:12 ` David E. Box
2021-06-03 7:17 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210531064655.GA1417@lst.de \
--to=hch@lst.de \
--cc=Alexander.Deucher@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=axboe@fb.com \
--cc=david.e.box@linux.intel.com \
--cc=jonathan.derrick@intel.com \
--cc=kbusch@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mario.limonciello@amd.com \
--cc=prike.liang@amd.com \
--cc=rjw@rjwysocki.net \
--cc=rrangel@chromium.org \
--cc=sagi@grimberg.me \
--cc=shyjumon.n@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox