From: Christoph Hellwig <hch@lst.de>
To: Mario Limonciello <mario.limonciello@amd.com>
Cc: Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@fb.com>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
"open list:NVM EXPRESS DRIVER" <linux-nvme@lists.infradead.org>,
linux-acpi@vger.kernel.org, rrangel@chromium.org,
david.e.box@linux.intel.com, Shyam-sundar.S-k@amd.com,
Nehal-bakulchandra.Shah@amd.com, Alexander.Deucher@amd.com,
prike.liang@amd.com,
"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>
Subject: Re: [PATCH v6 1/2] ACPI: Move check for _DSD StorageD3Enable property to acpi
Date: Tue, 8 Jun 2021 07:35:46 +0200 [thread overview]
Message-ID: <20210608053546.GA14116@lst.de> (raw)
In-Reply-To: <20210607173156.5548-1-mario.limonciello@amd.com>
On Mon, Jun 07, 2021 at 12:31:55PM -0500, Mario Limonciello wrote:
> +/**
> + * acpi_storage_d3 - Check if a storage device should use D3.
> + * @dev: Device to check
> + *
> + * Returns %true if @dev should be put into D3 when the ->suspend method is
> + * called, else %false. The name of this function is somewhat misleading
> + * as it has nothing to do with storage except for the name of the ACPI
> + * property. On some platforms resume will not work if this hint is ignored.
> + *
> + */
I still do not like this comment. There is nothing about only using this
for storage devices. It is specific to a PCIe slot, and if I plug
something that is not a storage device into it the same restrictions
still apply.
Also no need for the empty-ish line at the end.
next prev parent reply other threads:[~2021-06-08 5:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-07 17:31 [PATCH v6 1/2] ACPI: Move check for _DSD StorageD3Enable property to acpi Mario Limonciello
2021-06-07 17:31 ` [PATCH v6 2/2] ACPI: Add quirks for AMD Renoir/Lucienne CPUs to force the D3 hint Mario Limonciello
2021-06-07 17:38 ` Raul Rangel
2021-06-08 6:01 ` Julian Sikorski
2021-06-08 11:27 ` Rafael J. Wysocki
2021-06-08 5:35 ` Christoph Hellwig [this message]
2021-06-08 11:20 ` [PATCH v6 1/2] ACPI: Move check for _DSD StorageD3Enable property to acpi Rafael J. Wysocki
2021-06-08 14:18 ` Limonciello, Mario
2021-06-08 15:27 ` Rafael J. Wysocki
2021-06-08 20:01 ` Keith Busch
2021-06-09 13:00 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210608053546.GA14116@lst.de \
--to=hch@lst.de \
--cc=Alexander.Deucher@amd.com \
--cc=Nehal-bakulchandra.Shah@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=axboe@fb.com \
--cc=david.e.box@linux.intel.com \
--cc=kbusch@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mario.limonciello@amd.com \
--cc=prike.liang@amd.com \
--cc=rafael.j.wysocki@intel.com \
--cc=rjw@rjwysocki.net \
--cc=rrangel@chromium.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox