From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: linux-acpi@vger.kernel.org, linux-media@vger.kernel.org
Cc: andriy.shevchenko@linux.intel.com, rafael@kernel.org
Subject: [RFC 0/3] ACPI, PMICs and probing cameras
Date: Thu, 19 Aug 2021 23:19:33 +0300 [thread overview]
Message-ID: <20210819201936.7390-1-sakari.ailus@linux.intel.com> (raw)
Hi all,
The intel_skl_int3472 driver is required for some of the ACPI power state
transitions to function. This driver may be compiled as a module and thus
may probe after a sensor driver that depends on it (e.g. imx258).
Make the sensor driver return -EPROBE_DEFER if the sensor cannot be found.
This way the sensor driver will be probed when both the intel_skl_int3472
and the gpio-tps68470 drivers have successfully probed while also the
gpio-tps68470 driver may be built as a module.
The drawback of the approach is needless probing of the imx258 driver but
everything can be built as modules.
I'm posting this as RFC since the approach would require effectively all
ACPI based sensor drivers to have the same check. This would be a
non-issue to add. I wouldn't mind but...
Is there a way to figure out whether the PMIC opregion callbacks actually
succeed? At least the imx258 driver is happily probed even if the driver
implementing the opregion callback is not there, and thus the device
remains powered off --- and probe fails.
Sakari Ailus (3):
imx258: Defer probing on ident register read fail (on ACPI)
gpio-tps68470: Allow building as module
gpio-tps68470: Add modalias
drivers/gpio/Kconfig | 2 +-
drivers/gpio/gpio-tps68470.c | 5 ++++-
drivers/media/i2c/imx258.c | 8 ++++++++
3 files changed, 13 insertions(+), 2 deletions(-)
--
2.30.2
next reply other threads:[~2021-08-19 20:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-19 20:19 Sakari Ailus [this message]
2021-08-19 20:19 ` [RFC 1/3] imx258: Defer probing on ident register read fail (on ACPI) Sakari Ailus
2021-08-19 21:27 ` Laurent Pinchart
2021-08-24 15:51 ` Sakari Ailus
2021-08-20 12:20 ` Andy Shevchenko
2021-08-20 12:28 ` Sakari Ailus
2021-08-19 20:19 ` [RFC 2/3] gpio-tps68470: Allow building as module Sakari Ailus
2021-08-20 12:22 ` Andy Shevchenko
2021-08-19 20:19 ` [RFC 3/3] gpio-tps68470: Add modalias Sakari Ailus
2021-08-20 12:24 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210819201936.7390-1-sakari.ailus@linux.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox