From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: linux-acpi@vger.kernel.org, linux-media@vger.kernel.org
Cc: andriy.shevchenko@linux.intel.com, rafael@kernel.org
Subject: [RFC 1/3] imx258: Defer probing on ident register read fail (on ACPI)
Date: Thu, 19 Aug 2021 23:19:34 +0300 [thread overview]
Message-ID: <20210819201936.7390-2-sakari.ailus@linux.intel.com> (raw)
In-Reply-To: <20210819201936.7390-1-sakari.ailus@linux.intel.com>
Return -EPROBE_DEFER if probing the device fails because of the I²C
transaction (-EIO only). This generally happens when the power on sequence
of the device has not been fully performed yet due to later probing of
other drivers.
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
drivers/media/i2c/imx258.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/media/i2c/imx258.c b/drivers/media/i2c/imx258.c
index c249507aa2db..2751c12b6029 100644
--- a/drivers/media/i2c/imx258.c
+++ b/drivers/media/i2c/imx258.c
@@ -1109,6 +1109,14 @@ static int imx258_identify_module(struct imx258 *imx258)
ret = imx258_read_reg(imx258, IMX258_REG_CHIP_ID,
IMX258_REG_VALUE_16BIT, &val);
+ if (ret == -EIO && is_acpi_device_node(dev_fwnode(&client->dev))) {
+ /*
+ * If we get -EIO here and it's an ACPI device, there's a fair
+ * likelihood it's because the drivers required to power this
+ * device on have not probed yet. Thus return -EPROBE_DEFER.
+ */
+ return -EPROBE_DEFER;
+ }
if (ret) {
dev_err(&client->dev, "failed to read chip id %x\n",
IMX258_CHIP_ID);
--
2.30.2
next prev parent reply other threads:[~2021-08-19 20:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-19 20:19 [RFC 0/3] ACPI, PMICs and probing cameras Sakari Ailus
2021-08-19 20:19 ` Sakari Ailus [this message]
2021-08-19 21:27 ` [RFC 1/3] imx258: Defer probing on ident register read fail (on ACPI) Laurent Pinchart
2021-08-24 15:51 ` Sakari Ailus
2021-08-20 12:20 ` Andy Shevchenko
2021-08-20 12:28 ` Sakari Ailus
2021-08-19 20:19 ` [RFC 2/3] gpio-tps68470: Allow building as module Sakari Ailus
2021-08-20 12:22 ` Andy Shevchenko
2021-08-19 20:19 ` [RFC 3/3] gpio-tps68470: Add modalias Sakari Ailus
2021-08-20 12:24 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210819201936.7390-2-sakari.ailus@linux.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox