From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-acpi@vger.kernel.org, linux-media@vger.kernel.org,
rafael@kernel.org
Subject: Re: [RFC 1/3] imx258: Defer probing on ident register read fail (on ACPI)
Date: Fri, 20 Aug 2021 15:28:30 +0300 [thread overview]
Message-ID: <20210820122830.GA3@paasikivi.fi.intel.com> (raw)
In-Reply-To: <YR+eJytxRcVpSxgA@smile.fi.intel.com>
On Fri, Aug 20, 2021 at 03:20:55PM +0300, Andy Shevchenko wrote:
> On Thu, Aug 19, 2021 at 11:19:34PM +0300, Sakari Ailus wrote:
> > Return -EPROBE_DEFER if probing the device fails because of the I²C
> > transaction (-EIO only). This generally happens when the power on sequence
> > of the device has not been fully performed yet due to later probing of
> > other drivers.
>
> ...
>
> > + if (ret == -EIO && is_acpi_device_node(dev_fwnode(&client->dev))) {
>
> has_acpi_companion() is better to have here, no?
Agreed.
--
Sakari Ailus
next prev parent reply other threads:[~2021-08-20 12:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-19 20:19 [RFC 0/3] ACPI, PMICs and probing cameras Sakari Ailus
2021-08-19 20:19 ` [RFC 1/3] imx258: Defer probing on ident register read fail (on ACPI) Sakari Ailus
2021-08-19 21:27 ` Laurent Pinchart
2021-08-24 15:51 ` Sakari Ailus
2021-08-20 12:20 ` Andy Shevchenko
2021-08-20 12:28 ` Sakari Ailus [this message]
2021-08-19 20:19 ` [RFC 2/3] gpio-tps68470: Allow building as module Sakari Ailus
2021-08-20 12:22 ` Andy Shevchenko
2021-08-19 20:19 ` [RFC 3/3] gpio-tps68470: Add modalias Sakari Ailus
2021-08-20 12:24 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210820122830.GA3@paasikivi.fi.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox