Re: [PATCH v2 0/6] fw_devlink improvements

Marek Szyprowski
2021-09-15T08:44:39Z

Hi Saravana,

On 15.09.2021 10:11, Saravana Kannan wrote:
> Patches ready for picking up:
> Patch 1 fixes a bug in fw_devlink.
> Patch 2-4 are meant to make debugging easier
> Patch 5 and 6 fix fw_devlink issues with PHYs and networking

Is this patchset supposed to fix the PHY related issues I've experienced
or does it also require the Andrew's patch for 'mdio-parent-bus'? If the
first, then applying only this patchset on top of today's linux-next
doesn't fix the ethernet issue on my Amlogic SoC based test boards.

> Andrew,
>
> I think Patch 5 and 6 should be picked up be Greg too. Let me know if
> you disagree.
>
> -Saravana
>
> Cc: John Stultz <john.stultz@linaro.org>
> Cc: Marek Szyprowski <m.szyprowski@samsung.com>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Geert Uytterhoeven <geert@linux-m68k.org>
> Cc: Andrew Lunn <andrew@lunn.ch>
> Cc: Vladimir Oltean <olteanv@gmail.com>
>
> v1->v2:
> - Added a few Reviewed-by and Tested-by tags
> - Addressed Geert's comments in patches 3 and 5
> - Dropped the fw_devlink.debug patch
> - Added 2 more patches to the series to address other fw_devlink issues
>
> Thanks,
> Saravana
>
> Saravana Kannan (6):
> driver core: fw_devlink: Improve handling of cyclic dependencies
> driver core: Set deferred probe reason when deferred by driver core
> driver core: Create __fwnode_link_del() helper function
> driver core: Add debug logs when fwnode links are added/deleted
> driver core: fw_devlink: Add support for FWNODE_FLAG_NEEDS_CHILD_BOUND_ON_ADD
> net: mdiobus: Set FWNODE_FLAG_NEEDS_CHILD_BOUND_ON_ADD for mdiobus parents
>
> drivers/base/core.c | 90 ++++++++++++++++++++++++++------------
> drivers/net/phy/mdio_bus.c | 4 ++
> include/linux/fwnode.h | 11 +++--
> 3 files changed, 75 insertions(+), 30 deletions(-)
>
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland