From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 847FAC433F5 for ; Mon, 1 Nov 2021 14:58:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 62AAD61221 for ; Mon, 1 Nov 2021 14:58:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230261AbhKAPAj (ORCPT ); Mon, 1 Nov 2021 11:00:39 -0400 Received: from mga04.intel.com ([192.55.52.120]:51342 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229826AbhKAPAj (ORCPT ); Mon, 1 Nov 2021 11:00:39 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10154"; a="229757416" X-IronPort-AV: E=Sophos;i="5.87,199,1631602800"; d="scan'208";a="229757416" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Nov 2021 07:58:06 -0700 X-IronPort-AV: E=Sophos;i="5.87,199,1631602800"; d="scan'208";a="500067645" Received: from yingze1x-mobl.ccr.corp.intel.com (HELO chenyu5-mobl1) ([10.255.28.120]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Nov 2021 07:58:01 -0700 Date: Mon, 1 Nov 2021 22:57:57 +0800 From: Chen Yu To: Andy Shevchenko Cc: Greg Kroah-Hartman , linux-acpi@vger.kernel.org, "Rafael J. Wysocki" , Ard Biesheuvel , Len Brown , Ashok Raj , Mike Rapoport , Aubrey Li , linux-kernel@vger.kernel.org Subject: Re: [PATCH v7 2/4] drivers/acpi: Introduce Platform Firmware Runtime Update device driver Message-ID: <20211101145757.GA35522@chenyu5-mobl1> References: <20211101093320.GA18982@chenyu5-mobl1> <20211101131434.GA32880@chenyu5-mobl1> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Mon, Nov 01, 2021 at 04:08:08PM +0200, Andy Shevchenko wrote: > On Mon, Nov 01, 2021 at 02:16:41PM +0100, Greg Kroah-Hartman wrote: > > On Mon, Nov 01, 2021 at 09:14:34PM +0800, Chen Yu wrote: > > > On Mon, Nov 01, 2021 at 01:21:36PM +0200, Andy Shevchenko wrote: > > ... > > > > Ok, I'll switch to global variables in next version. > > > > Wait, no, why? > > But why should we have a duplication of basically static data? > > > Keep them per-device unless you can somehow be > > guaranteed there will never be more than one of these ACPI devices in a > > system. > > I guess you missed my point. These definitions are _always_ the same. > It does not matter how many devices in the system. > > Chen, is my perception correct? > If no, then do what Greg says. > Yes, there would be only one PFRU ACPI object in the system. And for PFRU Telemetry ACPI object, I don't know if the specification would introduce separate telemetry log using different uuid in the future - Currently there are two telemetry log buffers share the same uuid). Maybe for scalability reason we can make them per device. > > It's simpler this way, no need to worry about global state at > > all. > > Actually I have no idea why we even have strings in and not raw buffers. > Moreover, I haven't got why even we have them in uAPI. I see. These uuid could be put into the .c and there is no need for the user to be aware of these values. thanks, Chenyu > > -- > With Best Regards, > Andy Shevchenko > >