public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: linux-acpi@vger.kernel.org
Cc: John Ogness <john.ogness@linutronix.de>,
	rafael@kernel.org, mika.westerberg@linux.intel.com
Subject: [PATCH 1/3] ACPI: Make acpi_fwnode_handle safer
Date: Wed,  3 Nov 2021 15:34:04 +0200	[thread overview]
Message-ID: <20211103133406.659542-2-sakari.ailus@linux.intel.com> (raw)
In-Reply-To: <20211103133406.659542-1-sakari.ailus@linux.intel.com>

Check that the fwnode argument passed to acpi_fwnode_handle is non-NULL,
and return NULL if it is, otherwise the fwnode. Thus the caller doesn't
have to ensure the argument is a valid non-NULL fwnode.

Cc: stable@vger.kernel.org # v5.15 and up
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
 include/acpi/acpi_bus.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/acpi/acpi_bus.h b/include/acpi/acpi_bus.h
index 53b6e9f9de7b4..c34d94521d40c 100644
--- a/include/acpi/acpi_bus.h
+++ b/include/acpi/acpi_bus.h
@@ -445,7 +445,7 @@ static inline bool acpi_data_node_match(const struct fwnode_handle *fwnode,
 
 static inline struct fwnode_handle *acpi_fwnode_handle(struct acpi_device *adev)
 {
-	return &adev->fwnode;
+	return adev ? &adev->fwnode : NULL;
 }
 
 static inline void *acpi_driver_data(struct acpi_device *d)
-- 
2.30.2


  reply	other threads:[~2021-11-03 13:33 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-03 13:34 [PATCH 0/3] Get device's parent from parent field, fix sleeping IRQs disabled Sakari Ailus
2021-11-03 13:34 ` Sakari Ailus [this message]
2021-11-03 16:58   ` [PATCH 1/3] ACPI: Make acpi_fwnode_handle safer Andy Shevchenko
2021-11-03 17:55   ` Rafael J. Wysocki
2021-11-04 12:48     ` Sakari Ailus
2021-11-04 13:16     ` Sakari Ailus
2021-11-03 13:34 ` [PATCH 2/3] ACPI: Get acpi_device's parent from the parent field Sakari Ailus
2021-11-03 17:01   ` Andy Shevchenko
2021-11-03 17:48     ` Rafael J. Wysocki
2021-11-04 12:52       ` Sakari Ailus
2021-11-03 13:34 ` [PATCH 3/3] ACPI: Make acpi_node_get_parent() local Sakari Ailus
2021-11-03 17:02   ` Andy Shevchenko
2021-11-04 13:09     ` Sakari Ailus
2021-11-03 14:44 ` [PATCH 0/3] Get device's parent from parent field, fix sleeping IRQs disabled John Ogness
2021-11-03 15:47   ` Petr Mladek
2021-11-03 17:07     ` Andy Shevchenko
2021-11-04 12:45     ` Sakari Ailus
2021-11-03 15:49   ` Petr Mladek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211103133406.659542-2-sakari.ailus@linux.intel.com \
    --to=sakari.ailus@linux.intel.com \
    --cc=john.ogness@linutronix.de \
    --cc=linux-acpi@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    --cc=rafael@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox