Re: [PATCH v11 4/4] tools: Introduce power/acpi/tools/pfru

[Chen Yu <yu.c.chen@intel.com>]

On Tue, Dec 07, 2021 at 08:52:03PM +0100, Rafael J. Wysocki wrote:
> On Sun, Nov 21, 2021 at 4:18 PM Chen Yu <yu.c.chen@intel.com> wrote:
> >
> > Introduce a user space tool to make use of the interface exposed by
> > Platform Firmware Runtime Update and Telemetry drivers. The users
> > can use this tool to do firmware code injection, driver update and
> > to retrieve the telemetry data.
> >
> > Signed-off-by: Chen Yu <yu.c.chen@intel.com>
> > ---
> > v11:No change since v10.
> > v10:No change since v9.
> > v9: Add this tool into tools/power/acpi build infrastructure.
> >     (Andy Shevchenko)
> > v8: Print the length of OEM information if requested.
> > v7: No change since v6.
> > v6: Simplify the userspace tool to use while loop for getopt_long().
> >     (Andy Shevchenko)
> > v5: Replace the read() with mmap() so that the userspace
> >     could mmap once, and read multiple times. (Greg Kroah-Hartman)
> > ---
> >  tools/power/acpi/.gitignore          |   1 +
> >  tools/power/acpi/Makefile            |  16 +-
> >  tools/power/acpi/Makefile.rules      |   2 +-
> >  tools/power/acpi/man/pfru.8          | 137 +++++++++
> 
> I would call it pfrut, because it is for both the update and telemetry
> retrieval.
>
Ok, will change it. 
[cut]
> > diff --git a/tools/power/acpi/tools/pfru/pfru.c b/tools/power/acpi/tools/pfru/pfru.c
> > new file mode 100644
> > index 000000000000..eeec5043f825
> > --- /dev/null
> > +++ b/tools/power/acpi/tools/pfru/pfru.c
> > @@ -0,0 +1,417 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * Platform Firmware Runtime Update tool to do Management
> > + * Mode code injection/driver update and telemetry retrieval.
> 
> I would be good to say a bit more here, like what interfaces are used
> by this tool etc.
>
Ok, will do. 
> > +}
> > --
[cut]
> 
> Please adjust the patch for the build fixes sent separately.
> 
> Otherwise it is fine with me.
Ok, that patch has been sent separately.

thanks,
Chenyu