From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88E37C4332F for ; Wed, 8 Dec 2021 07:20:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244480AbhLHHYM (ORCPT ); Wed, 8 Dec 2021 02:24:12 -0500 Received: from mga09.intel.com ([134.134.136.24]:7164 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236023AbhLHHYL (ORCPT ); Wed, 8 Dec 2021 02:24:11 -0500 X-IronPort-AV: E=McAfee;i="6200,9189,10191"; a="237581905" X-IronPort-AV: E=Sophos;i="5.87,296,1631602800"; d="scan'208";a="237581905" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Dec 2021 23:20:38 -0800 X-IronPort-AV: E=Sophos;i="5.87,296,1631602800"; d="scan'208";a="515652550" Received: from chenyu-desktop.sh.intel.com (HELO chenyu-desktop) ([10.239.158.186]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Dec 2021 23:20:35 -0800 Date: Wed, 8 Dec 2021 15:20:22 +0800 From: Chen Yu To: "Rafael J. Wysocki" Cc: ACPI Devel Maling List , Greg Kroah-Hartman , Ard Biesheuvel , Len Brown , Ashok Raj , Andy Shevchenko , Mike Rapoport , Linux Kernel Mailing List , Robert Moore Subject: Re: [PATCH v11 4/4] tools: Introduce power/acpi/tools/pfru Message-ID: <20211208072022.GB261963@chenyu-desktop> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Tue, Dec 07, 2021 at 08:52:03PM +0100, Rafael J. Wysocki wrote: > On Sun, Nov 21, 2021 at 4:18 PM Chen Yu wrote: > > > > Introduce a user space tool to make use of the interface exposed by > > Platform Firmware Runtime Update and Telemetry drivers. The users > > can use this tool to do firmware code injection, driver update and > > to retrieve the telemetry data. > > > > Signed-off-by: Chen Yu > > --- > > v11:No change since v10. > > v10:No change since v9. > > v9: Add this tool into tools/power/acpi build infrastructure. > > (Andy Shevchenko) > > v8: Print the length of OEM information if requested. > > v7: No change since v6. > > v6: Simplify the userspace tool to use while loop for getopt_long(). > > (Andy Shevchenko) > > v5: Replace the read() with mmap() so that the userspace > > could mmap once, and read multiple times. (Greg Kroah-Hartman) > > --- > > tools/power/acpi/.gitignore | 1 + > > tools/power/acpi/Makefile | 16 +- > > tools/power/acpi/Makefile.rules | 2 +- > > tools/power/acpi/man/pfru.8 | 137 +++++++++ > > I would call it pfrut, because it is for both the update and telemetry > retrieval. > Ok, will change it. [cut] > > diff --git a/tools/power/acpi/tools/pfru/pfru.c b/tools/power/acpi/tools/pfru/pfru.c > > new file mode 100644 > > index 000000000000..eeec5043f825 > > --- /dev/null > > +++ b/tools/power/acpi/tools/pfru/pfru.c > > @@ -0,0 +1,417 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * Platform Firmware Runtime Update tool to do Management > > + * Mode code injection/driver update and telemetry retrieval. > > I would be good to say a bit more here, like what interfaces are used > by this tool etc. > Ok, will do. > > +} > > -- [cut] > > Please adjust the patch for the build fixes sent separately. > > Otherwise it is fine with me. Ok, that patch has been sent separately. thanks, Chenyu