From: Won Chung <wonchung@google.com>
To: "Rafael J . Wysocki" <rafael@kernel.org>,
Len Brown <lenb@kernel.org>, Benson Leung <bleung@chromium.org>,
Prashant Malani <pmalani@chromium.org>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Won Chung <wonchung@google.com>
Subject: [PATCH] ACPI: device_sysfs: Add sysfs support for _PLD
Date: Wed, 26 Jan 2022 23:58:07 +0000 [thread overview]
Message-ID: <20220126235807.3164317-1-wonchung@google.com> (raw)
When ACPI table includes _PLD fields for a device, create a new file
(pld) in sysfs to share _PLD fields.
Signed-off-by: Won Chung <wonchung@google.com>
---
drivers/acpi/device_sysfs.c | 42 +++++++++++++++++++++++++++++++++++++
1 file changed, 42 insertions(+)
diff --git a/drivers/acpi/device_sysfs.c b/drivers/acpi/device_sysfs.c
index d5d6403ba07b..8d4df5fb1c45 100644
--- a/drivers/acpi/device_sysfs.c
+++ b/drivers/acpi/device_sysfs.c
@@ -509,6 +509,40 @@ static ssize_t status_show(struct device *dev, struct device_attribute *attr,
}
static DEVICE_ATTR_RO(status);
+static ssize_t pld_show(struct device *dev, struct device_attribute *attr,
+ char *buf)
+{
+ struct acpi_device *acpi_dev = to_acpi_device(dev);
+ acpi_status status;
+ struct acpi_pld_info *pld;
+
+ status = acpi_get_physical_device_location(acpi_dev->handle, &pld);
+ if (ACPI_FAILURE(status))
+ return -ENODEV;
+
+ return sprintf(buf, "GROUP_TOKEN=%u\n"
+ "GROUP_POSITION=%u\n"
+ "USER_VISIBLE=%u\n"
+ "DOCK=%u\n"
+ "BAY=%u\n"
+ "LID=%u\n"
+ "PANEL=%u\n"
+ "HORIZONTAL_POSITION=%u\n"
+ "VERTICAL_POSITION=%u\n"
+ "SHAPE=%u\n",
+ pld->group_token,
+ pld->group_position,
+ pld->user_visible,
+ pld->dock,
+ pld->bay,
+ pld->lid,
+ pld->panel,
+ pld->horizontal_position,
+ pld->vertical_position,
+ pld->shape);
+}
+static DEVICE_ATTR_RO(pld);
+
/**
* acpi_device_setup_files - Create sysfs attributes of an ACPI device.
* @dev: ACPI device object.
@@ -595,6 +629,12 @@ int acpi_device_setup_files(struct acpi_device *dev)
&dev_attr_real_power_state);
}
+ if (acpi_has_method(dev->handle, "_PLD")) {
+ result = device_create_file(&dev->dev, &dev_attr_pld);
+ if (result)
+ goto end;
+ }
+
acpi_expose_nondev_subnodes(&dev->dev.kobj, &dev->data);
end:
@@ -645,4 +685,6 @@ void acpi_device_remove_files(struct acpi_device *dev)
device_remove_file(&dev->dev, &dev_attr_status);
if (dev->handle)
device_remove_file(&dev->dev, &dev_attr_path);
+ if (acpi_has_method(dev->handle, "_PLD"))
+ device_remove_file(&dev->dev, &dev_attr_pld);
}
--
2.35.0.rc0.227.g00780c9af4-goog
next reply other threads:[~2022-01-26 23:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-26 23:58 Won Chung [this message]
2022-01-27 20:37 ` [PATCH] ACPI: device_sysfs: Add sysfs support for _PLD Benson Leung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220126235807.3164317-1-wonchung@google.com \
--to=wonchung@google.com \
--cc=bleung@chromium.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmalani@chromium.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).