From: Daniel Scally <djrscally@gmail.com>
To: linux-acpi@vger.kernel.org, linux-clk@vger.kernel.org,
platform-driver-x86@vger.kernel.org
Cc: rafael@kernel.org, lenb@kernel.org, mturquette@baylibre.com,
sboyd@kernel.org, hdegoede@redhat.com, markgross@kernel.org,
robert.moore@intel.com
Subject: [PATCH 4/6] platform/x86: int3472: Add terminator to gpiod_lookup_table
Date: Wed, 16 Feb 2022 22:53:02 +0000 [thread overview]
Message-ID: <20220216225304.53911-5-djrscally@gmail.com> (raw)
In-Reply-To: <20220216225304.53911-1-djrscally@gmail.com>
Without the terminator, if a con_id is passed to gpio_find() that
does not exist in the lookup table the function will not stop looping
correctly, and eventually cause an oops.
Fixes: 1596ef1251b5 ("platform/x86: int3472: Pass tps68470_regulator_platform_data to the tps68470-regulator MFD-cell")
Signed-off-by: Daniel Scally <djrscally@gmail.com>
---
drivers/platform/x86/intel/int3472/tps68470_board_data.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/platform/x86/intel/int3472/tps68470_board_data.c b/drivers/platform/x86/intel/int3472/tps68470_board_data.c
index f93d437fd192..525f09a3b5ff 100644
--- a/drivers/platform/x86/intel/int3472/tps68470_board_data.c
+++ b/drivers/platform/x86/intel/int3472/tps68470_board_data.c
@@ -100,7 +100,8 @@ static struct gpiod_lookup_table surface_go_tps68470_gpios = {
.dev_id = "i2c-INT347A:00",
.table = {
GPIO_LOOKUP("tps68470-gpio", 9, "reset", GPIO_ACTIVE_LOW),
- GPIO_LOOKUP("tps68470-gpio", 7, "powerdown", GPIO_ACTIVE_LOW)
+ GPIO_LOOKUP("tps68470-gpio", 7, "powerdown", GPIO_ACTIVE_LOW),
+ { }
}
};
--
2.25.1
next prev parent reply other threads:[~2022-02-16 22:53 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-16 22:52 [PATCH 0/6] Add multiple-consumer support to int3472-tps68470 driver Daniel Scally
2022-02-16 22:52 ` [PATCH 1/6] ACPI: scan: Add acpi_dev_get_next_consumer_dev() Daniel Scally
2022-02-21 9:50 ` Hans de Goede
2022-02-21 9:51 ` Hans de Goede
2022-02-16 22:53 ` [PATCH 2/6] ACPI: bus: Add iterator for dependent devices Daniel Scally
2022-02-21 9:52 ` Hans de Goede
2022-02-16 22:53 ` [PATCH 3/6] platform/x86: int3472: Support multiple clock consumers Daniel Scally
2022-02-17 3:22 ` kernel test robot
2022-02-22 14:44 ` Hans de Goede
2022-02-22 14:47 ` Daniel Scally
2022-02-21 9:59 ` Hans de Goede
2022-02-25 0:49 ` Stephen Boyd
2022-02-25 9:22 ` Hans de Goede
2022-02-16 22:53 ` Daniel Scally [this message]
2022-02-21 10:00 ` [PATCH 4/6] platform/x86: int3472: Add terminator to gpiod_lookup_table Hans de Goede
2022-02-21 13:46 ` Hans de Goede
2022-02-16 22:53 ` [PATCH 5/6] platform/x86: int3472: Support multiple gpio lookups in board data Daniel Scally
2022-02-21 10:03 ` Hans de Goede
2022-02-16 22:53 ` [PATCH 6/6] platform/x86: int3472: Add board data for Surface Go2 IR camera Daniel Scally
2022-02-21 10:05 ` Hans de Goede
2022-02-17 9:55 ` [PATCH 0/6] Add multiple-consumer support to int3472-tps68470 driver Hans de Goede
2022-02-18 8:45 ` Daniel Scally
2022-02-21 10:07 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220216225304.53911-5-djrscally@gmail.com \
--to=djrscally@gmail.com \
--cc=hdegoede@redhat.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=mturquette@baylibre.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=robert.moore@intel.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox