Re: [PATCH v1 1/3] ACPI: platform: Constify properties parameter in acpi_create_platform_device()

Rafael J. Wysocki
2022-03-01T19:38:27Z

On Thu, Feb 24, 2022 at 12:56 AM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> Properties are not and should not be changed in the callee, hence constify
> properties parameter in acpi_create_platform_device().
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/acpi/acpi_platform.c | 2 +-
> include/linux/acpi.h | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/acpi/acpi_platform.c b/drivers/acpi/acpi_platform.c
> index 78d621290a35..de3cbf152dee 100644
> --- a/drivers/acpi/acpi_platform.c
> +++ b/drivers/acpi/acpi_platform.c
> @@ -95,7 +95,7 @@ static void acpi_platform_fill_resource(struct acpi_device *adev,
> * Name of the platform device will be the same as @adev's.
> */
> struct platform_device *acpi_create_platform_device(struct acpi_device *adev,
> - struct property_entry *properties)
> + const struct property_entry *properties)
> {
> struct platform_device *pdev = NULL;
> struct platform_device_info pdevinfo;
> diff --git a/include/linux/acpi.h b/include/linux/acpi.h
> index 6274758648e3..9ac545379447 100644
> --- a/include/linux/acpi.h
> +++ b/include/linux/acpi.h
> @@ -691,7 +691,7 @@ int acpi_device_uevent_modalias(struct device *, struct kobj_uevent_env *);
> int acpi_device_modalias(struct device *, char *, int);
>
> struct platform_device *acpi_create_platform_device(struct acpi_device *,
> - struct property_entry *);
> + const struct property_entry *);
> #define ACPI_PTR(_ptr) (_ptr)
>
> static inline void acpi_device_set_enumerated(struct acpi_device *adev)
> @@ -930,7 +930,7 @@ static inline int acpi_device_modalias(struct device *dev,
>
> static inline struct platform_device *
> acpi_create_platform_device(struct acpi_device *adev,
> - struct property_entry *properties)
> + const struct property_entry *properties)
> {
> return NULL;
> }
> --

Applied as 5.18 material along with the rest of the series, thanks!