From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B62CDC433F5 for ; Mon, 14 Mar 2022 09:12:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231993AbiCNJOD (ORCPT ); Mon, 14 Mar 2022 05:14:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41470 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236683AbiCNJOC (ORCPT ); Mon, 14 Mar 2022 05:14:02 -0400 Received: from bmailout3.hostsharing.net (bmailout3.hostsharing.net [IPv6:2a01:4f8:150:2161:1:b009:f23e:0]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 20A155F6F; Mon, 14 Mar 2022 02:12:51 -0700 (PDT) Received: from h08.hostsharing.net (h08.hostsharing.net [83.223.95.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.hostsharing.net", Issuer "RapidSSL TLS DV RSA Mixed SHA256 2020 CA-1" (verified OK)) by bmailout3.hostsharing.net (Postfix) with ESMTPS id DEF78100D587D; Mon, 14 Mar 2022 10:12:47 +0100 (CET) Received: by h08.hostsharing.net (Postfix, from userid 100393) id B63014ABF3; Mon, 14 Mar 2022 10:12:47 +0100 (CET) Date: Mon, 14 Mar 2022 10:12:47 +0100 From: Lukas Wunner To: Mario Limonciello Cc: Hans de Goede , Mark Gross , "Rafael J . Wysocki" , "open list:X86 PLATFORM DRIVERS" , linux-acpi@vger.kernel.org, Shyam Sundar S K , Goswami Sanket Subject: Re: [PATCH v3 1/5] ACPI / x86: Add support for LPS0 callback handler Message-ID: <20220314091247.GA28904@wunner.de> References: <20220314050340.1176-1-mario.limonciello@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220314050340.1176-1-mario.limonciello@amd.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Mon, Mar 14, 2022 at 12:03:35AM -0500, Mario Limonciello wrote: > Currenty the latest thing run during a suspend to idle attempt is > the LPS0 `prepare_late` callback and the earliest thing is the > `resume_early` callback. > > There is a desire for the `amd-pmc` driver to suspend later in the > suspend process (ideally the very last thing), so create a callback > that it or any other driver can hook into to do this. I'm wondering if this can be solved with much less code by either using device links (a device link to amd-pmc from everything that needs to be suspended before it), or with a notifier chain? Thanks, Lukas