Re: [PATCH v3 3/3] acpi/pci_root: negotiate CXL _OSC

[Bjorn Helgaas <helgaas@kernel.org>]

On Wed, Mar 30, 2022 at 08:16:29PM +0000, Verma, Vishal L wrote:
> On Wed, 2022-03-30 at 14:01 -0500, Bjorn Helgaas wrote:

> > > Reported-by: kernel test robot <lkp@intel.com>
> > 
> > What was reported by the robot?  If it just complained about something
> > in v1 or v2, I think there's no point in mentioning this here.  It's
> > the same as ordinary review comments (like these I'm composing), and
> > they don't need to be acknowledged.  I think "Reported-by" is great
> > when giving credit for bug fixes, but that's not what's happening
> > here.
> 
> Correct it was a compile warning, and actually it wasn't on-list - 0day
> sent it privately, because it was on the RFC version. It makes sense to
> treat it as a normal review comment - I only added the tag because the
> 0day emails ask you to (I suppose they use the trailers for metrics on
> actionable feedback generated by the bot). I'm happy to drop it if
> that's preferred here.

Yeah, I know.  I *love* the 0-day bot and the fact that it tests
things before they're even merged, but I wish it would only ask you to
add the tag if it's something that has already been merged, where the
likely outcome is a tiny bug-fix patch where it's obvious what
"Reported-by" refers to.

Bjorn