From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38D48C433F5 for ; Wed, 30 Mar 2022 20:30:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348693AbiC3Ucd (ORCPT ); Wed, 30 Mar 2022 16:32:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49394 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343988AbiC3Ucc (ORCPT ); Wed, 30 Mar 2022 16:32:32 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6D0D727CFD; Wed, 30 Mar 2022 13:30:47 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 19FA8B81E43; Wed, 30 Mar 2022 20:30:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7F192C340EE; Wed, 30 Mar 2022 20:30:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1648672244; bh=MpuyXUhrwGWQwGjgaZyRKPlXjzMLU3CKzApXThgr71I=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=ZrWNSTrmtoyfYyOoKDsgRc9I/eZFdstGlLvHRaXtOjTwMXQAmPR5H1EV9MjGEIifW Rhr0Q009uhNPOkmk1dIfc4I8AQAqxffEsSDXgC5e36rsgWb/oRfmhsbdBEDgxzuhYe e+KBSwKJlcUj3NF6pd7mQlihWyynt2oDKUrj2JzYpc4mV+vNU3nHupZqcASXGgZnGh CkJYx9EJtSeMUlaj/X1M8McVuchMcF0yEbxfBujBx0A3t2UueCusVOrdHQ+/MtLXMy cBEo4A+wc1+v8GlYjV/11fXpq81QIi5+sJ7Oa3upLN/Z/YUQPFsVRe+k60F2Omx4vg SeQ6mGJBZyN+g== Date: Wed, 30 Mar 2022 15:30:42 -0500 From: Bjorn Helgaas To: "Verma, Vishal L" Cc: lkp , "rafael@kernel.org" , "linux-cxl@vger.kernel.org" , "Jonathan.Cameron@Huawei.com" , "Williams, Dan J" , "linux-acpi@vger.kernel.org" , "Wysocki, Rafael J" , "Moore, Robert" , "bhelgaas@google.com" , "dave@stgolabs.net" Subject: Re: [PATCH v3 3/3] acpi/pci_root: negotiate CXL _OSC Message-ID: <20220330203042.GA1707046@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4a6543cf79e66ecd5ec5c15da5bec74d3602cb07.camel@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Wed, Mar 30, 2022 at 08:16:29PM +0000, Verma, Vishal L wrote: > On Wed, 2022-03-30 at 14:01 -0500, Bjorn Helgaas wrote: > > > Reported-by: kernel test robot > > > > What was reported by the robot?  If it just complained about something > > in v1 or v2, I think there's no point in mentioning this here.  It's > > the same as ordinary review comments (like these I'm composing), and > > they don't need to be acknowledged.  I think "Reported-by" is great > > when giving credit for bug fixes, but that's not what's happening > > here. > > Correct it was a compile warning, and actually it wasn't on-list - 0day > sent it privately, because it was on the RFC version. It makes sense to > treat it as a normal review comment - I only added the tag because the > 0day emails ask you to (I suppose they use the trailers for metrics on > actionable feedback generated by the bot). I'm happy to drop it if > that's preferred here. Yeah, I know. I *love* the 0-day bot and the fact that it tests things before they're even merged, but I wish it would only ask you to add the tag if it's something that has already been merged, where the likely outcome is a tiny bug-fix patch where it's obvious what "Reported-by" refers to. Bjorn