Re: [PATCH] ACPI: Avoid flush_scheduled_work() usage

[kernel test robot <lkp@intel.com>]

Hi Tetsuo,

I love your patch! Yet something to improve:

[auto build test ERROR on rafael-pm/linux-next]
[also build test ERROR on v5.18-rc3 next-20220419]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/intel-lab-lkp/linux/commits/Tetsuo-Handa/ACPI-Avoid-flush_scheduled_work-usage/20220419-215854
base:   https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
config: i386-randconfig-a013 (https://download.01.org/0day-ci/archive/20220420/202204200917.Gi0wjcgM-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project c1c49a356162b22554088d269f7689bdb044a9f1)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/cebc6c01f6fac86f7deaf74ca81311d9c3d179f4
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Tetsuo-Handa/ACPI-Avoid-flush_scheduled_work-usage/20220419-215854
        git checkout cebc6c01f6fac86f7deaf74ca81311d9c3d179f4
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> drivers/acpi/acpi_video.c:1640:21: error: use of undeclared identifier 'acpi_wq'
           queue_delayed_work(acpi_wq, &video_device->switch_brightness_work, HZ / 10);
                              ^
   drivers/acpi/acpi_video.c:2258:6: warning: no previous prototype for function 'acpi_video_unregister_backlight' [-Wmissing-prototypes]
   void acpi_video_unregister_backlight(void)
        ^
   drivers/acpi/acpi_video.c:2258:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   void acpi_video_unregister_backlight(void)
   ^
   static 
   1 warning and 1 error generated.
--
>> drivers/acpi/video_detect.c:532:14: error: use of undeclared identifier 'acpi_wq'
                   queue_work(acpi_wq, &backlight_notify_work);
                              ^
   drivers/acpi/video_detect.c:605:13: warning: no previous prototype for function 'acpi_video_detect_exit' [-Wmissing-prototypes]
   void __exit acpi_video_detect_exit(void)
               ^
   drivers/acpi/video_detect.c:605:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   void __exit acpi_video_detect_exit(void)
   ^
   static 
   1 warning and 1 error generated.


vim +/acpi_wq +1640 drivers/acpi/acpi_video.c

  1632	
  1633	static void brightness_switch_event(struct acpi_video_device *video_device,
  1634					    u32 event)
  1635	{
  1636		if (!brightness_switch_enabled)
  1637			return;
  1638	
  1639		video_device->switch_brightness_event = event;
> 1640		queue_delayed_work(acpi_wq, &video_device->switch_brightness_work, HZ / 10);
  1641	}
  1642	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp