Re: [PATCH v11 1/9] iommu: Introduce a callback to struct iommu_resv_region

Lu Baolu
2022-04-23T06:39:30Z

On 2022/4/23 13:14, Christoph Hellwig wrote:
> On Sat, Apr 23, 2022 at 10:04:39AM +0800, Lu Baolu wrote:
>> The generic_iommu_put_resv_regions() itself is a callback. Why bothering
>> adding another callback from the same iommu driver in it? Or, you are
>> going to remove the put_resv_regions from the iommu ops?
>
> It is a driver method, but these reserved entries are not actually
> allocated by the driver. And I do have a patch pending removing this
> driver method that should never have been a driver method, check
> the iomm list archives for
>
> iommu: remove the put_resv_regions method
>

Yeah! That's a good idea.

Best regards,
baolu