Re: [PATCH v11 0/9] ACPI/IORT: Support for IORT RMR node

Steven Price
2022-04-28T14:43:53Z

On 22/04/2022 17:28, Shameer Kolothum wrote:
> Hi
>
> v9 --> v10
>  -Addressed Christoph's comments. We now have a callback to
> struct iommu_resv_region to free all related memory and also dropped
> the FW specific union and now has a container struct iommu_iort_rmr_data.
> See patches #1 & #4
> -Added R-by from Christoph.
> -Dropped R-by from Lorenzo for patches #4 & #5 due to the above changes.
> -Also dropped T-by from Steve and Laurentiu. Many thanks for your test
> efforts. I have done basic sanity testing on my platform but please
> give it a try at your end as well.

I'm back in the office and given it a spin, it's all good:

Tested-by: Steven Price <steven.price@arm.com>

Thanks,

Steve

>
> As mentioned in v10, this now has a dependency on the ACPICA header patch
> here[1].
>
> Please take a look and let me know.
>
> Thanks,
> Shameer
> [1] https://lore.kernel.org/all/44610361.fMDQidcC6G@kreacher/
>
> From old:
> We have faced issues with 3408iMR RAID controller cards which
> fail to boot when SMMU is enabled. This is because these
> controllers make use of host memory for various caching related
> purposes and when SMMU is enabled the iMR firmware fails to
> access these memory regions as there is no mapping for them.
> IORT RMR provides a way for UEFI to describe and report these
> memory regions so that the kernel can make a unity mapping for
> these in SMMU.
>
> Change History:
>
> v9 --> v10
> - Dropped patch #1 ("Add temporary RMR node flag definitions") since
> the ACPICA header updates patch is now in the mailing list
> - Based on the suggestion from Christoph, introduced a
> resv_region_free_fw_data() callback in struct iommu_resv_region and
> used that to free RMR specific memory allocations.
>
> v8 --> v9
>  - Adressed comments from Robin on interfaces.
>  - Addressed comments from Lorenzo.
>
> v7 --> v8
>   - Patch #1 has temp definitions for RMR related changes till
>     the ACPICA header changes are part of kernel.
>   - No early parsing of RMR node info and is only parsed at the
>     time of use.
>   - Changes to the RMR get/put API format compared to the
>     previous version.
>   - Support for RMR descriptor shared by multiple stream IDs.
>
> v6 --> v7
>  -fix pointed out by Steve to the SMMUv2 SMR bypass install in patch #8.
>
> v5 --> v6
> - Addressed comments from Robin & Lorenzo.
>   : Moved iort_parse_rmr() to acpi_iort_init() from
>     iort_init_platform_devices().
>   : Removed use of struct iort_rmr_entry during the initial
>     parse. Using struct iommu_resv_region instead.
>   : Report RMR address alignment and overlap errors, but continue.
>   : Reworked arm_smmu_init_bypass_stes() (patch # 6).
> - Updated SMMUv2 bypass SMR code. Thanks to Jon N (patch #8).
> - Set IOMMU protection flags(IOMMU_CACHE, IOMMU_MMIO) based
>   on Type of RMR region. Suggested by Jon N.
>
> v4 --> v5
>  -Added a fw_data union to struct iommu_resv_region and removed
>   struct iommu_rmr (Based on comments from Joerg/Robin).
>  -Added iommu_put_rmrs() to release mem.
>  -Thanks to Steve for verifying on SMMUv2, but not added the Tested-by
>   yet because of the above changes.
>
> v3 -->v4
> -Included the SMMUv2 SMR bypass install changes suggested by
>  Steve(patch #7)
> -As per Robin's comments, RMR reserve implementation is now
>  more generic  (patch #8) and dropped v3 patches 8 and 10.
> -Rebase to 5.13-rc1
>
> RFC v2 --> v3
>  -Dropped RFC tag as the ACPICA header changes are now ready to be
>   part of 5.13[0]. But this series still has a dependency on that patch.
>  -Added IORT E.b related changes(node flags, _DSM function 5 checks for
>   PCIe).
>  -Changed RMR to stream id mapping from M:N to M:1 as per the spec and
>   discussion here[1].
>  -Last two patches add support for SMMUv2(Thanks to Jon Nettleton!)
>
> Jon Nettleton (1):
> iommu/arm-smmu: Get associated RMR info and install bypass SMR
>
> Shameer Kolothum (8):
> iommu: Introduce a callback to struct iommu_resv_region
> ACPI/IORT: Make iort_iommu_msi_get_resv_regions() return void
> ACPI/IORT: Provide a generic helper to retrieve reserve regions
> ACPI/IORT: Add support to retrieve IORT RMR reserved regions
> ACPI/IORT: Add a helper to retrieve RMR info directly
> iommu/arm-smmu-v3: Introduce strtab init helper
> iommu/arm-smmu-v3: Refactor arm_smmu_init_bypass_stes() to force
> bypass
> iommu/arm-smmu-v3: Get associated RMR info and install bypass STE
>
> drivers/acpi/arm64/iort.c | 359 ++++++++++++++++++--
> drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 78 ++++-
> drivers/iommu/arm/arm-smmu/arm-smmu.c | 52 +++
> drivers/iommu/dma-iommu.c | 2 +-
> drivers/iommu/iommu.c | 16 +-
> include/linux/acpi_iort.h | 14 +-
> include/linux/iommu.h | 10 +
> 7 files changed, 485 insertions(+), 46 deletions(-)
>