From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: linux-kernel@vger.kernel.org
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Aubrey Li <aubrey.li@linux.intel.com>,
Hans de Goede <hdegoede@redhat.com>, Len Brown <lenb@kernel.org>,
linux-acpi@vger.kernel.org, Mark Gross <markgross@kernel.org>,
platform-driver-x86@vger.kernel.org,
"Rafael J. Wysocki" <rafael@kernel.org>,
Paul Gortmaker <paul.gortmaker@windriver.com>
Subject: [PATCH 0/4] platform: allow ATOM PMC code to be optional
Date: Thu, 28 Apr 2022 02:24:26 -0400 [thread overview]
Message-ID: <20220428062430.31010-1-paul.gortmaker@windriver.com> (raw)
A few months back I was doing a test build for "defconfig-like" COTS
hardware and happened to notice some pmc-atom stuff being built. Fine,
I thought - the defconfig isn't minimal - we all know that - what Kconfig
do I use to turn that off? Well, imagine my surprise when I found out
you couldn't turn it [Atom Power Management Controller] code off!
Normally we all agree to not use "default y" unless unavoidable, but
somehow this was added as "def_bool y" which is even worse ; you can
see the Kconfig setting but there is *no* way you can turn it off.
After investigating, I found no reason why the atom code couldn't be
opt-out with just minor changes that the original addition overlooked.
And so this series addreses that. I tried to be sensitive to not
break any existing configs in the process, but the defconfig will
now intentionally be different and exclude this atom specific code.
Using a defconfig on today's linux-next, here is the delta summary:
$ ./scripts/bloat-o-meter -c ../pmc-atom-pre/vmlinux ../pmc-atom-post/vmlinux|grep add/remove
add/remove: 0/410 grow/shrink: 0/7 up/down: 0/-47659 (-47659)
add/remove: 0/105 grow/shrink: 0/1 up/down: 0/-6848 (-6848)
add/remove: 0/56 grow/shrink: 0/1 up/down: 0/-10155 (-10155)
$ ./scripts/bloat-o-meter -c ../pmc-atom-pre/vmlinux ../pmc-atom-post/vmlinux|grep Total
Total: Before=13626994, After=13579335, chg -0.35%
Total: Before=3572137, After=3565289, chg -0.19%
Total: Before=1235335, After=1225180, chg -0.82%
It is hard to reclaim anything against the inevitable growth in
footprint, so I'd say we should be glad to take whatever we can.
Boot tested defconfig on today's linux-next on older non-atom COTS.
Paul.
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Aubrey Li <aubrey.li@linux.intel.com>
Cc: Hans de Goede <hdegoede@redhat.com>
Cc: Len Brown <lenb@kernel.org>
Cc: linux-acpi@vger.kernel.org
Cc: Mark Gross <markgross@kernel.org>
Cc: platform-driver-x86@vger.kernel.org
Cc: "Rafael J. Wysocki" <rafael@kernel.org>
---
Paul Gortmaker (4):
platform/x86: pmc_atom: remove unused pmc_atom_write()
ACPI: LPSS: make the Kconfig dependency on PMC_ATOM explicit
platform/x86: pmc_atom: dont export pmc_atom_read - no modular users
platform/x86: pmc_atom: make the PMC driver actually unselectable
arch/x86/Kconfig | 1 +
drivers/platform/x86/Kconfig | 11 ++++++++---
drivers/platform/x86/pmc_atom.c | 13 -------------
include/linux/platform_data/x86/pmc_atom.h | 1 -
4 files changed, 9 insertions(+), 17 deletions(-)
--
2.17.1
next reply other threads:[~2022-04-28 6:25 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-28 6:24 Paul Gortmaker [this message]
2022-04-28 6:24 ` [PATCH 1/4] platform/x86: pmc_atom: remove unused pmc_atom_write() Paul Gortmaker
2022-04-28 10:29 ` Andy Shevchenko
2022-05-06 10:43 ` Hans de Goede
2022-04-28 6:24 ` [PATCH 2/4] ACPI: LPSS: make the Kconfig dependency on PMC_ATOM explicit Paul Gortmaker
2022-04-28 10:35 ` Andy Shevchenko
2022-05-05 19:03 ` Rafael J. Wysocki
2022-04-28 6:24 ` [PATCH 3/4] platform/x86: pmc_atom: dont export pmc_atom_read - no modular users Paul Gortmaker
2022-05-06 10:43 ` Hans de Goede
2022-04-28 6:24 ` [PATCH 4/4] platform/x86: pmc_atom: make the PMC driver actually unselectable Paul Gortmaker
2022-04-28 10:20 ` Andy Shevchenko
2022-05-02 14:45 ` Hans de Goede
2022-04-28 10:12 ` [PATCH 0/4] platform: allow ATOM PMC code to be optional Andy Shevchenko
2022-04-28 18:11 ` Paul Gortmaker
2022-04-29 12:34 ` Andy Shevchenko
2022-05-02 14:30 ` Hans de Goede
2022-05-02 16:05 ` Andy Shevchenko
2022-05-03 7:48 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220428062430.31010-1-paul.gortmaker@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=aubrey.li@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox