From: Li Zhong <floridsleeves@gmail.com>
To: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org
Cc: rafael@kernel.org, lenb@kernel.org, mario.limonciello@amd.com,
hdegoede@redhat.com, Shyam-sundar.S-k@amd.com,
mika.westerberg@linux.intel.com, nakato@nakato.io,
lily <floridsleeves@gmail.com>
Subject: [PATCH v1] drivers/acpi/x86: check return null pointer from acpi_evaluate_dsm()
Date: Sun, 28 Aug 2022 13:51:20 -0700 [thread overview]
Message-ID: <20220828205120.1956222-1-floridsleeves@gmail.com> (raw)
From: lily <floridsleeves@gmail.com>
Check return value from acpi_evaluate_dsm(). Only do ACPI_FREE() when
out_obj is not NULL pointers.
Signed-off-by: Li Zhong <floridsleeves@gmail.com>
---
drivers/acpi/x86/s2idle.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/acpi/x86/s2idle.c b/drivers/acpi/x86/s2idle.c
index f9ac12b778e6..1b449d3cfbf7 100644
--- a/drivers/acpi/x86/s2idle.c
+++ b/drivers/acpi/x86/s2idle.c
@@ -328,7 +328,8 @@ static void acpi_sleep_run_lps0_dsm(unsigned int func, unsigned int func_mask, g
out_obj = acpi_evaluate_dsm(lps0_device_handle, &dsm_guid,
rev_id, func, NULL);
- ACPI_FREE(out_obj);
+ if (!out_obj)
+ ACPI_FREE(out_obj);
acpi_handle_debug(lps0_device_handle, "_DSM function %u evaluation %s\n",
func, out_obj ? "successful" : "failed");
--
2.25.1
next reply other threads:[~2022-08-28 20:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-28 20:51 Li Zhong [this message]
2022-08-29 5:13 ` [PATCH v1] drivers/acpi/x86: check return null pointer from acpi_evaluate_dsm() Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220828205120.1956222-1-floridsleeves@gmail.com \
--to=floridsleeves@gmail.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=hdegoede@redhat.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=mika.westerberg@linux.intel.com \
--cc=nakato@nakato.io \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox