From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8E49C433FE for ; Tue, 11 Oct 2022 09:21:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229591AbiJKJVE (ORCPT ); Tue, 11 Oct 2022 05:21:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57710 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229461AbiJKJVC (ORCPT ); Tue, 11 Oct 2022 05:21:02 -0400 Received: from outbound-smtp51.blacknight.com (outbound-smtp51.blacknight.com [46.22.136.235]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1F2734CA1C for ; Tue, 11 Oct 2022 02:20:54 -0700 (PDT) Received: from mail.blacknight.com (pemlinmail04.blacknight.ie [81.17.254.17]) by outbound-smtp51.blacknight.com (Postfix) with ESMTPS id 9B0C0FA7ED for ; Tue, 11 Oct 2022 10:20:52 +0100 (IST) Received: (qmail 28527 invoked from network); 11 Oct 2022 09:20:52 -0000 Received: from unknown (HELO techsingularity.net) (mgorman@techsingularity.net@[84.203.198.246]) by 81.17.254.9 with ESMTPSA (AES256-SHA encrypted, authenticated); 11 Oct 2022 09:20:52 -0000 Date: Tue, 11 Oct 2022 10:20:50 +0100 From: Mel Gorman To: "Rafael J. Wysocki" Cc: "Rafael J. Wysocki" , linux-rtc@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: Intermittent boot failure after 6492fed7d8c9 (v6.0-rc1) Message-ID: <20221011092050.gnh3dr5iqdvvrgs5@techsingularity.net> References: <20221010141630.zfzi7mk7zvnmclzy@techsingularity.net> <20221010174526.3yi7nziokwwpr63s@techsingularity.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Mon, Oct 10, 2022 at 08:29:05PM +0200, Rafael J. Wysocki wrote: > > It failed 3/10 times. > > This is still not acceptable. > Agreed. > > That's less than the previous 5/10 failures but I > > cannot be certain it helped without running a lot more boot tests. The > > failure happens in the same function as before. > > I've overlooked the fact that acpi_install_fixed_event_handler() > enables the event on success, so it is a bug to call it when the > handler is not ready. > > It should help to only enable the event after running cmos_do_probe() > where the driver data pointer is set, so please try the attached > patch. Looks good and it booted 10 times successfully. -- Mel Gorman SUSE Labs