From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC5E3C43217 for ; Thu, 20 Oct 2022 08:20:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229610AbiJTIUK (ORCPT ); Thu, 20 Oct 2022 04:20:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52948 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229658AbiJTIUI (ORCPT ); Thu, 20 Oct 2022 04:20:08 -0400 X-Greylist: delayed 565 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Thu, 20 Oct 2022 01:20:05 PDT Received: from outbound-smtp39.blacknight.com (outbound-smtp39.blacknight.com [46.22.139.222]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2B35B79EDC for ; Thu, 20 Oct 2022 01:20:04 -0700 (PDT) Received: from mail.blacknight.com (pemlinmail05.blacknight.ie [81.17.254.26]) by outbound-smtp39.blacknight.com (Postfix) with ESMTPS id 1B5D829BC for ; Thu, 20 Oct 2022 09:10:37 +0100 (IST) Received: (qmail 8911 invoked from network); 20 Oct 2022 08:10:36 -0000 Received: from unknown (HELO techsingularity.net) (mgorman@techsingularity.net@[84.203.198.246]) by 81.17.254.9 with ESMTPSA (AES256-SHA encrypted, authenticated); 20 Oct 2022 08:10:36 -0000 Date: Thu, 20 Oct 2022 09:10:35 +0100 From: Mel Gorman To: "Rafael J. Wysocki" Cc: Alexandre Belloni , Alessandro Zummo , Mario Limonciello , linux-rtc@vger.kernel.org, Bjorn Helgaas , LKML , Linux ACPI , Linux PM , Zhang Rui , Todd Brandt Subject: Re: [PATCH] rtc: rtc-cmos: Fix wake alarm breakage Message-ID: <20221020081035.4lafnpunbacrhdqs@techsingularity.net> References: <5887691.lOV4Wx5bFT@kreacher> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <5887691.lOV4Wx5bFT@kreacher> Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Tue, Oct 18, 2022 at 06:09:31PM +0200, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > Commit 4919d3eb2ec0 ("rtc: cmos: Fix event handler registration > ordering issue") overlooked the fact that cmos_do_probe() depended > on the preparations carried out by cmos_wake_setup() and the wake > alarm stopped working after the ordering of them had been changed. > > Address this by partially reverting commit 4919d3eb2ec0 so that > cmos_wake_setup() is called before cmos_do_probe() again and moving > the rtc_wake_setup() invocation from cmos_wake_setup() directly to the > callers of cmos_do_probe() where it will happen after a successful > completion of the latter. > > Fixes: 4919d3eb2ec0 ("rtc: cmos: Fix event handler registration ordering issue") > Reported-by: Zhang Rui > Reported-by: Todd Brandt > Signed-off-by: Rafael J. Wysocki Boot test that previously hit NULL pointer exceptions also completed successfully. -- Mel Gorman SUSE Labs