From: Bjorn Helgaas <helgaas@kernel.org>
To: Yipeng Zou <zouyipeng@huawei.com>
Cc: rafael@kernel.org, lenb@kernel.org, bhelgaas@google.com,
tn@semihalf.com, linux-acpi@vger.kernel.org,
linux-pci@vger.kernel.org
Subject: Re: [PATCH] PCI/ACPI: use ACPI Method Name macro directly
Date: Mon, 7 Nov 2022 15:24:48 -0600 [thread overview]
Message-ID: <20221107212448.GA421592@bhelgaas> (raw)
In-Reply-To: <20221104032430.186424-1-zouyipeng@huawei.com>
On Fri, Nov 04, 2022 at 11:24:30AM +0800, Yipeng Zou wrote:
> It's convenience to find all at once, use METHOD_NAME__UID as path string.
>
> Fixes: 169de969c018 ("PCI/ACPI: Provide acpi_get_rc_resources() for ARM64 platform")
> Signed-off-by: Yipeng Zou <zouyipeng@huawei.com>
Applied to pci/misc for v6.2, thanks!
I dropped the "Fixes:" tag because there's no reason to backport this
to any older kernels.
I assume you're doing the same for other instances?
drivers/acpi/acpi_processor.c: status = acpi_evaluate_integer(handle, "_UID", NULL, &uid);
drivers/acpi/dock.c: "_UID", NULL, &lbuf);
drivers/acpi/processor_pdc.c: status = acpi_evaluate_integer(handle, "_UID", NULL, &tmp);
drivers/perf/hisilicon/hisi_uncore_hha_pmu.c: "_UID", NULL, &id);
drivers/xen/xen-acpi-processor.c: status = acpi_evaluate_integer(handle, "_UID", NULL, &tmp);
> ---
> drivers/pci/pci-acpi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/pci-acpi.c b/drivers/pci/pci-acpi.c
> index a46fec776ad7..068d6745bf98 100644
> --- a/drivers/pci/pci-acpi.c
> +++ b/drivers/pci/pci-acpi.c
> @@ -67,7 +67,7 @@ static acpi_status acpi_match_rc(acpi_handle handle, u32 lvl, void *context,
> unsigned long long uid;
> acpi_status status;
>
> - status = acpi_evaluate_integer(handle, "_UID", NULL, &uid);
> + status = acpi_evaluate_integer(handle, METHOD_NAME__UID, NULL, &uid);
> if (ACPI_FAILURE(status) || uid != *segment)
> return AE_CTRL_DEPTH;
>
> --
> 2.17.1
>
next prev parent reply other threads:[~2022-11-07 21:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-04 3:24 [PATCH] PCI/ACPI: use ACPI Method Name macro directly Yipeng Zou
2022-11-07 21:24 ` Bjorn Helgaas [this message]
2022-11-08 1:25 ` Yipeng Zou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221107212448.GA421592@bhelgaas \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=tn@semihalf.com \
--cc=zouyipeng@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox