* [PATCH v3 9/9] cxl/acpi: Set ACPI's CXL _OSC to indicate CXL1.1 support
[not found] <20221109104059.766720-1-rrichter@amd.com>
@ 2022-11-09 10:40 ` Robert Richter
2022-11-09 12:22 ` Rafael J. Wysocki
2022-11-09 23:35 ` Bjorn Helgaas
0 siblings, 2 replies; 6+ messages in thread
From: Robert Richter @ 2022-11-09 10:40 UTC (permalink / raw)
To: Alison Schofield, Vishal Verma, Ira Weiny, Ben Widawsky,
Dan Williams, Bjorn Helgaas, Rafael J. Wysocki
Cc: linux-cxl, linux-kernel, Len Brown, Jonathan Cameron,
Davidlohr Bueso, Dave Jiang, Robert Richter, Terry Bowman,
linux-pci, linux-acpi
From: Terry Bowman <terry.bowman@amd.com>
ACPI includes a CXL _OSC support procedure to communicate the available
CXL support to FW. The CXL support _OSC includes a field to indicate
CXL1.1 RCH RCD support. The OS sets this bit to 1 if it supports access
to RCD and RCH Port registers.[1] FW can potentially change it's operation
depending on the _OSC support setting reported by the OS.
The ACPI driver does not currently set the ACPI _OSC support to indicate
CXL1.1 RCD RCH support. Change the capability reported to include CXL1.1.
[1] CXL3.0 Table 9-26 'Interpretation of CXL _OSC Support Field'
Signed-off-by: Terry Bowman <terry.bowman@amd.com>
Signed-off-by: Robert Richter <rrichter@amd.com>
---
drivers/acpi/pci_root.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/acpi/pci_root.c b/drivers/acpi/pci_root.c
index c8385ef54c37..094a59b216ae 100644
--- a/drivers/acpi/pci_root.c
+++ b/drivers/acpi/pci_root.c
@@ -492,6 +492,7 @@ static u32 calculate_cxl_support(void)
u32 support;
support = OSC_CXL_2_0_PORT_DEV_REG_ACCESS_SUPPORT;
+ support |= OSC_CXL_1_1_PORT_REG_ACCESS_SUPPORT;
if (pci_aer_available())
support |= OSC_CXL_PROTOCOL_ERR_REPORTING_SUPPORT;
if (IS_ENABLED(CONFIG_HOTPLUG_PCI_PCIE))
--
2.30.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v3 9/9] cxl/acpi: Set ACPI's CXL _OSC to indicate CXL1.1 support
2022-11-09 10:40 ` [PATCH v3 9/9] cxl/acpi: Set ACPI's CXL _OSC to indicate CXL1.1 support Robert Richter
@ 2022-11-09 12:22 ` Rafael J. Wysocki
2022-11-09 23:35 ` Bjorn Helgaas
1 sibling, 0 replies; 6+ messages in thread
From: Rafael J. Wysocki @ 2022-11-09 12:22 UTC (permalink / raw)
To: Robert Richter
Cc: Alison Schofield, Vishal Verma, Ira Weiny, Ben Widawsky,
Dan Williams, Bjorn Helgaas, Rafael J. Wysocki, linux-cxl,
linux-kernel, Len Brown, Jonathan Cameron, Davidlohr Bueso,
Dave Jiang, Terry Bowman, linux-pci, linux-acpi
On Wed, Nov 9, 2022 at 11:41 AM Robert Richter <rrichter@amd.com> wrote:
>
> From: Terry Bowman <terry.bowman@amd.com>
>
> ACPI includes a CXL _OSC support procedure to communicate the available
> CXL support to FW. The CXL support _OSC includes a field to indicate
> CXL1.1 RCH RCD support. The OS sets this bit to 1 if it supports access
> to RCD and RCH Port registers.[1] FW can potentially change it's operation
> depending on the _OSC support setting reported by the OS.
>
> The ACPI driver does not currently set the ACPI _OSC support to indicate
> CXL1.1 RCD RCH support. Change the capability reported to include CXL1.1.
>
> [1] CXL3.0 Table 9-26 'Interpretation of CXL _OSC Support Field'
>
> Signed-off-by: Terry Bowman <terry.bowman@amd.com>
> Signed-off-by: Robert Richter <rrichter@amd.com>
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---
> drivers/acpi/pci_root.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/acpi/pci_root.c b/drivers/acpi/pci_root.c
> index c8385ef54c37..094a59b216ae 100644
> --- a/drivers/acpi/pci_root.c
> +++ b/drivers/acpi/pci_root.c
> @@ -492,6 +492,7 @@ static u32 calculate_cxl_support(void)
> u32 support;
>
> support = OSC_CXL_2_0_PORT_DEV_REG_ACCESS_SUPPORT;
> + support |= OSC_CXL_1_1_PORT_REG_ACCESS_SUPPORT;
> if (pci_aer_available())
> support |= OSC_CXL_PROTOCOL_ERR_REPORTING_SUPPORT;
> if (IS_ENABLED(CONFIG_HOTPLUG_PCI_PCIE))
> --
> 2.30.2
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3 9/9] cxl/acpi: Set ACPI's CXL _OSC to indicate CXL1.1 support
2022-11-09 10:40 ` [PATCH v3 9/9] cxl/acpi: Set ACPI's CXL _OSC to indicate CXL1.1 support Robert Richter
2022-11-09 12:22 ` Rafael J. Wysocki
@ 2022-11-09 23:35 ` Bjorn Helgaas
2022-11-10 0:51 ` Verma, Vishal L
2022-11-10 19:43 ` Terry Bowman
1 sibling, 2 replies; 6+ messages in thread
From: Bjorn Helgaas @ 2022-11-09 23:35 UTC (permalink / raw)
To: Robert Richter
Cc: Alison Schofield, Vishal Verma, Ira Weiny, Ben Widawsky,
Dan Williams, Bjorn Helgaas, Rafael J. Wysocki, linux-cxl,
linux-kernel, Len Brown, Jonathan Cameron, Davidlohr Bueso,
Dave Jiang, Terry Bowman, linux-pci, linux-acpi
On Wed, Nov 09, 2022 at 11:40:59AM +0100, Robert Richter wrote:
> From: Terry Bowman <terry.bowman@amd.com>
>
> ACPI includes a CXL _OSC support procedure to communicate the available
> CXL support to FW. The CXL support _OSC includes a field to indicate
> CXL1.1 RCH RCD support. The OS sets this bit to 1 if it supports access
> to RCD and RCH Port registers.[1] FW can potentially change it's operation
s/it's/its/
> depending on the _OSC support setting reported by the OS.
>
> The ACPI driver does not currently set the ACPI _OSC support to indicate
> CXL1.1 RCD RCH support. Change the capability reported to include CXL1.1.
Eight instances of "support" above seems like it might be more than
necessary.
I don't know the history, but OSC_CXL_1_1_PORT_REG_ACCESS_SUPPORT and
OSC_CXL_2_0_PORT_DEV_REG_ACCESS_SUPPORT seem like sort of weird names
since they don't match the spec at all ("RCD and RCH Port Register
Access Supported" and "CXL VH Register Access Supported").
> [1] CXL3.0 Table 9-26 'Interpretation of CXL _OSC Support Field'
>
> Signed-off-by: Terry Bowman <terry.bowman@amd.com>
> Signed-off-by: Robert Richter <rrichter@amd.com>
> ---
> drivers/acpi/pci_root.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/acpi/pci_root.c b/drivers/acpi/pci_root.c
> index c8385ef54c37..094a59b216ae 100644
> --- a/drivers/acpi/pci_root.c
> +++ b/drivers/acpi/pci_root.c
> @@ -492,6 +492,7 @@ static u32 calculate_cxl_support(void)
> u32 support;
>
> support = OSC_CXL_2_0_PORT_DEV_REG_ACCESS_SUPPORT;
> + support |= OSC_CXL_1_1_PORT_REG_ACCESS_SUPPORT;
> if (pci_aer_available())
> support |= OSC_CXL_PROTOCOL_ERR_REPORTING_SUPPORT;
> if (IS_ENABLED(CONFIG_HOTPLUG_PCI_PCIE))
> --
> 2.30.2
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3 9/9] cxl/acpi: Set ACPI's CXL _OSC to indicate CXL1.1 support
2022-11-09 23:35 ` Bjorn Helgaas
@ 2022-11-10 0:51 ` Verma, Vishal L
2022-11-10 17:10 ` Bjorn Helgaas
2022-11-10 19:43 ` Terry Bowman
1 sibling, 1 reply; 6+ messages in thread
From: Verma, Vishal L @ 2022-11-10 0:51 UTC (permalink / raw)
To: helgaas@kernel.org, rrichter@amd.com
Cc: terry.bowman@amd.com, Jiang, Dave, rafael@kernel.org,
Schofield, Alison, linux-cxl@vger.kernel.org, lenb@kernel.org,
linux-kernel@vger.kernel.org, Williams, Dan J, Weiny, Ira,
bwidawsk@kernel.org, Jonathan.Cameron@huawei.com,
bhelgaas@google.com, dave@stgolabs.net,
linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org
On Wed, 2022-11-09 at 17:35 -0600, Bjorn Helgaas wrote:
> On Wed, Nov 09, 2022 at 11:40:59AM +0100, Robert Richter wrote:
> > From: Terry Bowman <terry.bowman@amd.com>
> >
> > ACPI includes a CXL _OSC support procedure to communicate the available
> > CXL support to FW. The CXL support _OSC includes a field to indicate
> > CXL1.1 RCH RCD support. The OS sets this bit to 1 if it supports access
> > to RCD and RCH Port registers.[1] FW can potentially change it's operation
>
> s/it's/its/
>
> > depending on the _OSC support setting reported by the OS.
> >
> > The ACPI driver does not currently set the ACPI _OSC support to indicate
> > CXL1.1 RCD RCH support. Change the capability reported to include CXL1.1.
>
> Eight instances of "support" above seems like it might be more than
> necessary.
>
> I don't know the history, but OSC_CXL_1_1_PORT_REG_ACCESS_SUPPORT and
> OSC_CXL_2_0_PORT_DEV_REG_ACCESS_SUPPORT seem like sort of weird names
> since they don't match the spec at all ("RCD and RCH Port Register
> Access Supported" and "CXL VH Register Access Supported").
Ah the RCH/RCD and VH terminology was only introduced in the CXL-3.0
spec. When the above defines were added, the spec was at 2.0, and it
used the descriptions: "CXL 1.1 Port Register Access supported", and
"CXL 2.0 Port/Device Register Access supported" (Table 217 in 2.0).
>
> > [1] CXL3.0 Table 9-26 'Interpretation of CXL _OSC Support Field'
> >
> > Signed-off-by: Terry Bowman <terry.bowman@amd.com>
> > Signed-off-by: Robert Richter <rrichter@amd.com>
> > ---
> > drivers/acpi/pci_root.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/acpi/pci_root.c b/drivers/acpi/pci_root.c
> > index c8385ef54c37..094a59b216ae 100644
> > --- a/drivers/acpi/pci_root.c
> > +++ b/drivers/acpi/pci_root.c
> > @@ -492,6 +492,7 @@ static u32 calculate_cxl_support(void)
> > u32 support;
> >
> > support = OSC_CXL_2_0_PORT_DEV_REG_ACCESS_SUPPORT;
> > + support |= OSC_CXL_1_1_PORT_REG_ACCESS_SUPPORT;
> > if (pci_aer_available())
> > support |= OSC_CXL_PROTOCOL_ERR_REPORTING_SUPPORT;
> > if (IS_ENABLED(CONFIG_HOTPLUG_PCI_PCIE))
> > --
> > 2.30.2
> >
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3 9/9] cxl/acpi: Set ACPI's CXL _OSC to indicate CXL1.1 support
2022-11-10 0:51 ` Verma, Vishal L
@ 2022-11-10 17:10 ` Bjorn Helgaas
0 siblings, 0 replies; 6+ messages in thread
From: Bjorn Helgaas @ 2022-11-10 17:10 UTC (permalink / raw)
To: Verma, Vishal L
Cc: rrichter@amd.com, terry.bowman@amd.com, Jiang, Dave,
rafael@kernel.org, Schofield, Alison, linux-cxl@vger.kernel.org,
lenb@kernel.org, linux-kernel@vger.kernel.org, Williams, Dan J,
Weiny, Ira, bwidawsk@kernel.org, Jonathan.Cameron@huawei.com,
bhelgaas@google.com, dave@stgolabs.net,
linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org
On Thu, Nov 10, 2022 at 12:51:02AM +0000, Verma, Vishal L wrote:
> On Wed, 2022-11-09 at 17:35 -0600, Bjorn Helgaas wrote:
> > I don't know the history, but OSC_CXL_1_1_PORT_REG_ACCESS_SUPPORT and
> > OSC_CXL_2_0_PORT_DEV_REG_ACCESS_SUPPORT seem like sort of weird names
> > since they don't match the spec at all ("RCD and RCH Port Register
> > Access Supported" and "CXL VH Register Access Supported").
>
> Ah the RCH/RCD and VH terminology was only introduced in the CXL-3.0
> spec. When the above defines were added, the spec was at 2.0, and it
> used the descriptions: "CXL 1.1 Port Register Access supported", and
> "CXL 2.0 Port/Device Register Access supported" (Table 217 in 2.0).
Haha, that's annoying :) I didn't dig back through the old versions.
I guess CXL folks can decide whether to keep the old names or update.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3 9/9] cxl/acpi: Set ACPI's CXL _OSC to indicate CXL1.1 support
2022-11-09 23:35 ` Bjorn Helgaas
2022-11-10 0:51 ` Verma, Vishal L
@ 2022-11-10 19:43 ` Terry Bowman
1 sibling, 0 replies; 6+ messages in thread
From: Terry Bowman @ 2022-11-10 19:43 UTC (permalink / raw)
To: Bjorn Helgaas, Robert Richter
Cc: Alison Schofield, Vishal Verma, Ira Weiny, Ben Widawsky,
Dan Williams, Bjorn Helgaas, Rafael J. Wysocki, linux-cxl,
linux-kernel, Len Brown, Jonathan Cameron, Davidlohr Bueso,
Dave Jiang, linux-pci, linux-acpi
On 11/9/22 17:35, Bjorn Helgaas wrote:
> On Wed, Nov 09, 2022 at 11:40:59AM +0100, Robert Richter wrote:
>> From: Terry Bowman <terry.bowman@amd.com>
>>
>> ACPI includes a CXL _OSC support procedure to communicate the available
>> CXL support to FW. The CXL support _OSC includes a field to indicate
>> CXL1.1 RCH RCD support. The OS sets this bit to 1 if it supports access
>> to RCD and RCH Port registers.[1] FW can potentially change it's operation
>
> s/it's/its/
>
Ok, will fix.
>> depending on the _OSC support setting reported by the OS.
>>
>> The ACPI driver does not currently set the ACPI _OSC support to indicate
>> CXL1.1 RCD RCH support. Change the capability reported to include CXL1.1.
>
> Eight instances of "support" above seems like it might be more than
> necessary.
>
> I don't know the history, but OSC_CXL_1_1_PORT_REG_ACCESS_SUPPORT and
> OSC_CXL_2_0_PORT_DEV_REG_ACCESS_SUPPORT seem like sort of weird names
> since they don't match the spec at all ("RCD and RCH Port Register
> Access Supported" and "CXL VH Register Access Supported").
>
I'll reword to not excessively reuse 'support'. Thanks for point out.
Regards,
Terry
>> [1] CXL3.0 Table 9-26 'Interpretation of CXL _OSC Support Field'
>>
>> Signed-off-by: Terry Bowman <terry.bowman@amd.com>
>> Signed-off-by: Robert Richter <rrichter@amd.com>
>> ---
>> drivers/acpi/pci_root.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/acpi/pci_root.c b/drivers/acpi/pci_root.c
>> index c8385ef54c37..094a59b216ae 100644
>> --- a/drivers/acpi/pci_root.c
>> +++ b/drivers/acpi/pci_root.c
>> @@ -492,6 +492,7 @@ static u32 calculate_cxl_support(void)
>> u32 support;
>>
>> support = OSC_CXL_2_0_PORT_DEV_REG_ACCESS_SUPPORT;
>> + support |= OSC_CXL_1_1_PORT_REG_ACCESS_SUPPORT;
>> if (pci_aer_available())
>> support |= OSC_CXL_PROTOCOL_ERR_REPORTING_SUPPORT;
>> if (IS_ENABLED(CONFIG_HOTPLUG_PCI_PCIE))
>> --
>> 2.30.2
>>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-11-10 19:43 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20221109104059.766720-1-rrichter@amd.com>
2022-11-09 10:40 ` [PATCH v3 9/9] cxl/acpi: Set ACPI's CXL _OSC to indicate CXL1.1 support Robert Richter
2022-11-09 12:22 ` Rafael J. Wysocki
2022-11-09 23:35 ` Bjorn Helgaas
2022-11-10 0:51 ` Verma, Vishal L
2022-11-10 17:10 ` Bjorn Helgaas
2022-11-10 19:43 ` Terry Bowman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox