From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B59AC4321E for ; Wed, 23 Nov 2022 10:03:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237194AbiKWKD4 (ORCPT ); Wed, 23 Nov 2022 05:03:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55646 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237475AbiKWKCQ (ORCPT ); Wed, 23 Nov 2022 05:02:16 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 5ED69FAE98; Wed, 23 Nov 2022 01:54:27 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 69F981FB; Wed, 23 Nov 2022 01:54:33 -0800 (PST) Received: from bogus (unknown [10.57.6.137]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3EEAB3F587; Wed, 23 Nov 2022 01:54:24 -0800 (PST) Date: Wed, 23 Nov 2022 09:54:21 +0000 From: Sudeep Holla To: Jiapeng Chong Cc: rafael@kernel.org, lenb@kernel.org, linux-acpi@vger.kernel.org, Sudeep Holla , linux-kernel@vger.kernel.org, Abaci Robot Subject: Re: [PATCH] ACPI: bus: make osc_sb_ffh_opregion_support_confirmed static Message-ID: <20221123095421.ffolxbq2csqirw7u@bogus> References: <20221123034215.119461-1-jiapeng.chong@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221123034215.119461-1-jiapeng.chong@linux.alibaba.com> Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Wed, Nov 23, 2022 at 11:42:15AM +0800, Jiapeng Chong wrote: > This symbol is not used outside of bus.c, so marks it static. > > drivers/acpi/bus.c:304:6: warning: symbol 'osc_sb_ffh_opregion_support_confirmed' was not declared. Should it be static? > > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3241 > Reported-by: Abaci Robot Sorry for not replying to the original report which I meant to and for some reason left it in the draft. Anyways in order to fix another bug, this variable was removed thereby removing this build/sparse warning. This warning should not appear from today's linux-next. Thanks for spotting and this patch fixing it. -- Regards, Sudeep