From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2EF4C4167B for ; Sat, 17 Dec 2022 15:31:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230000AbiLQPbf (ORCPT ); Sat, 17 Dec 2022 10:31:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33422 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230049AbiLQPa7 (ORCPT ); Sat, 17 Dec 2022 10:30:59 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 299E215F3A; Sat, 17 Dec 2022 07:28:34 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B8D5060C14; Sat, 17 Dec 2022 15:28:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 76AAAC43398; Sat, 17 Dec 2022 15:28:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1671290913; bh=scuxibib/wgWJbiVOJ780gC72KxWU3lhTW97mM5HxNo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=sP2rN0jq5z/Tdsw1IWhf3YHsOoX1c9dbOYVbZ5IZ0iF4n+cdOtS9PNbP39OLWGJzQ yxqsbE+ctwAiaYnDHSHXyp52UtdvpW60o78pwTNoh+RVEpLCIFbmVq5Aj1UXmg0t8+ /+zeJ8nU7UENoLTcvCLrdsURA7+28xeIS/OH6LsD1WmJNgIKhrTYtLnngp8MH0NJcb GknDdQ9ii8SLiCw1760Ioctu6z+fKUKdrYRAIeipPlalQhUHP4+JTQnbcWL3sWXoyX 2bBe2qahX3kf2aF2mfTJbNAoEnnf/8ntWJkGTeiMJt4fjorY/HH0+qSDBr4M2JDkyQ y/tJXNFGjPS3w== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Li Zhong , "Rafael J . Wysocki" , Sasha Levin , rafael@kernel.org, linux-acpi@vger.kernel.org Subject: [PATCH AUTOSEL 6.0 05/16] ACPI: processor: idle: Check acpi_fetch_acpi_dev() return value Date: Sat, 17 Dec 2022 10:28:08 -0500 Message-Id: <20221217152821.98618-5-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221217152821.98618-1-sashal@kernel.org> References: <20221217152821.98618-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org From: Li Zhong [ Upstream commit 2437513a814b3e93bd02879740a8a06e52e2cf7d ] The return value of acpi_fetch_acpi_dev() could be NULL, which would cause a NULL pointer dereference to occur in acpi_device_hid(). Signed-off-by: Li Zhong [ rjw: Subject and changelog edits, added empty line after if () ] Signed-off-by: Rafael J. Wysocki Signed-off-by: Sasha Levin --- drivers/acpi/processor_idle.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c index 9f40917c49ef..4d1dd255c122 100644 --- a/drivers/acpi/processor_idle.c +++ b/drivers/acpi/processor_idle.c @@ -1134,6 +1134,9 @@ static int acpi_processor_get_lpi_info(struct acpi_processor *pr) status = acpi_get_parent(handle, &pr_ahandle); while (ACPI_SUCCESS(status)) { d = acpi_fetch_acpi_dev(pr_ahandle); + if (!d) + break; + handle = pr_ahandle; if (strcmp(acpi_device_hid(d), ACPI_PROCESSOR_CONTAINER_HID)) -- 2.35.1