Re: [PATCH v3 0/3] Thermal ACPI APIs for generic trip points

Daniel Lezcano
2023-01-06T13:25:10Z

On 06/01/2023 09:25, Zhang, Rui wrote:
> Hi, Daniel,
>
> On Wed, 2023-01-04 at 23:21 +0100, Daniel Lezcano wrote:
>> Recently sent as a RFC, the thermal ACPI for generic trip points is a
>> set of
>> functions to fill the generic trip points structure which will become
>> the
>> standard structure for the thermal framework and its users.
>>
>> Different Intel drivers and the ACPI thermal driver are using the
>> ACPI tables to
>> get the thermal zone information. As those are getting the same
>> information,
>> providing this set of ACPI function with the generic trip points will
>> consolidate the code.
>
> My understanding is that the ACPI thermal driver
> (drivers/acpi/thermal.c) should be one of the top users of these APIs.

Yes, correct.

> Is there any specific reason that it is not included in this patch
> series? or is it just that you don't have ACPI thermal driver running
> on your test platform?

The generic trip point handling in the acpi thermal driver is another
story. Some code reorg and cleanup should be done before. I have a
series for that but I need to test it more. That is the reason why it
will be submitted after this series is reviewed, so the changes will be
focused on the acpi thermal driver only.

I have a laptop with acpitz but only the critical trip temp.

--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |