linux-acpi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Ira Weiny <ira.weiny@intel.com>
Cc: Dan Williams <dan.j.williams@intel.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Alison Schofield <alison.schofield@intel.com>,
	Vishal Verma <vishal.l.verma@intel.com>,
	Davidlohr Bueso <dave@stgolabs.net>,
	Dave Jiang <dave.jiang@intel.com>,
	Ben Widawsky <bwidawsk@kernel.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	<linux-kernel@vger.kernel.org>, <linux-pci@vger.kernel.org>,
	<linux-acpi@vger.kernel.org>, <linux-cxl@vger.kernel.org>
Subject: Re: [PATCH v6 6/8] cxl/test: Add generic mock events
Date: Fri, 13 Jan 2023 13:27:03 +0000	[thread overview]
Message-ID: <20230113132703.0000664a@Huawei.com> (raw)
In-Reply-To: <20221216-cxl-ev-log-v6-6-346583105b30@intel.com>

On Mon, 09 Jan 2023 11:42:25 -0800
Ira Weiny <ira.weiny@intel.com> wrote:

> Facilitate testing basic Get/Clear Event functionality by creating
> multiple logs and generic events with made up UUID's.
> 
> Data is completely made up with data patterns which should be easy to
> spot in trace output.
> 
> A single sysfs entry resets the event data and triggers collecting the
> events for testing.
> 
> Test traces are easy to obtain with a small script such as this:
> 
> 	#!/bin/bash -x
> 
> 	devices=`find /sys/devices/platform -name cxl_mem*`
> 
> 	# Turn on tracing
> 	echo "" > /sys/kernel/tracing/trace
> 	echo 1 > /sys/kernel/tracing/events/cxl/enable
> 	echo 1 > /sys/kernel/tracing/tracing_on
> 
> 	# Generate fake interrupt
> 	for device in $devices; do
> 	        echo 1 > $device/event_trigger
> 	done
> 
> 	# Turn off tracing and report events
> 	echo 0 > /sys/kernel/tracing/tracing_on
> 	cat /sys/kernel/tracing/trace
> 
> Reviewed-by: Dan Williams <dan.j.williams@intel.com>
> Signed-off-by: Ira Weiny <ira.weiny@intel.com>

Looks like it will test the kernel functionality in this
patch set correctly to me. 

Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>


  reply	other threads:[~2023-01-13 13:34 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-09 19:42 [PATCH v6 0/8] cxl: Process event logs Ira Weiny
2023-01-09 19:42 ` [PATCH v6 1/8] cxl/mem: Read, trace, and clear events on driver load Ira Weiny
2023-01-13 12:22   ` Jonathan Cameron
2023-01-18  1:03     ` Ira Weiny
2023-01-09 19:42 ` [PATCH v6 2/8] cxl/mem: Wire up event interrupts ira.weiny
2023-01-13 12:28   ` Jonathan Cameron
2023-01-13 21:45     ` Ira Weiny
2023-01-09 19:42 ` [PATCH v6 3/8] cxl/mem: Trace General Media Event Record Ira Weiny
2023-01-13 12:34   ` Jonathan Cameron
2023-01-13 17:16   ` Davidlohr Bueso
2023-01-09 19:42 ` [PATCH v6 4/8] cxl/mem: Trace DRAM " Ira Weiny
2023-01-13 12:36   ` Jonathan Cameron
2023-01-13 19:09   ` Davidlohr Bueso
2023-01-09 19:42 ` [PATCH v6 5/8] cxl/mem: Trace Memory Module " Ira Weiny
2023-01-13 12:41   ` Jonathan Cameron
2023-01-18  1:12     ` Ira Weiny
2023-01-09 19:42 ` [PATCH v6 6/8] cxl/test: Add generic mock events Ira Weiny
2023-01-13 13:27   ` Jonathan Cameron [this message]
2023-01-09 19:42 ` [PATCH v6 7/8] cxl/test: Add specific events Ira Weiny
2023-01-09 19:42 ` [PATCH v6 8/8] cxl/test: Simulate event log overflow Ira Weiny

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230113132703.0000664a@Huawei.com \
    --to=jonathan.cameron@huawei.com \
    --cc=alison.schofield@intel.com \
    --cc=bhelgaas@google.com \
    --cc=bwidawsk@kernel.org \
    --cc=dan.j.williams@intel.com \
    --cc=dave.jiang@intel.com \
    --cc=dave@stgolabs.net \
    --cc=ira.weiny@intel.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-cxl@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=vishal.l.verma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).