public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Orlando Chamberlain <orlandoch.dev@gmail.com>
To: gargaditya08@live.com
Cc: andy@infradead.org, hdegoede@redhat.com, lenb@kernel.org,
	linux-acpi@vger.kernel.org, lukas@wunner.de,
	mgross@linux.intel.com, platform-driver-x86@vger.kernel.org,
	rafael@kernel.org
Subject: Re: [PATCH 0/3] ACPI: video/apple-gmux: Improve apple-gmux backlight detection
Date: Tue, 24 Jan 2023 19:21:03 +1100	[thread overview]
Message-ID: <20230124192103.71673c69@redecorated-mbp> (raw)
In-Reply-To: <4E707490-819D-448A-904F-CD8028894CE2@live.com>

> > Aditya, can you perhaps test this on a model macbook which does
> > actually use the apple-gmux driver for backlight control
> > (assuming you have such a model) ?
> > 
>
> Hi Hans
>
> Since I own a T2 MacBook, I’ll have to apply some out of tree patches as well
> from https://github.com/Redecorating/linux/commits/bits/010 gmux. I’ve
> requested the maintainer although he believes they shouldn't break anything on
> T2 Macs. I’ve still let a kernel compile without the out of tree patches, just
> with yours and shall send the outputs by tomorrow.

I'm the one that wrote those patches for gmux on the mmio T2 macs, and
I've rebased them onto Hans' patchset with patch numbers 2004-2006 here
https://github.com/t2linux/linux-t2-patches/tree/gmux

It seems to work fine on my T2 Macbookpro16,1, the display backlight
controls work and there aren't any other, not working, backlights
present.

> ls /sys/class/backlight
gmux_backlight@

  reply	other threads:[~2023-01-24  8:21 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-23 11:37 [PATCH 0/3] ACPI: video/apple-gmux: Improve apple-gmux backlight detection Hans de Goede
2023-01-23 11:37 ` [PATCH 1/3] platform/x86: apple-gmux: Move port defines to apple-gmux.h Hans de Goede
2023-01-23 11:37 ` [PATCH 2/3] platform/x86: apple-gmux: Add apple_gmux_detect() helper Hans de Goede
2023-01-23 13:49   ` Lukas Wunner
2023-01-23 14:13     ` Hans de Goede
2023-01-23 14:23       ` Lukas Wunner
2023-01-23 15:05         ` Hans de Goede
2023-01-23 15:10           ` Hans de Goede
2023-01-23 16:35   ` Andy Shevchenko
2023-01-23 11:37 ` [PATCH 3/3] ACPI: video: Fix apple gmux detection Hans de Goede
2023-01-23 16:37   ` Andy Shevchenko
2023-01-23 17:25     ` Hans de Goede
2023-01-23 19:20   ` Rafael J. Wysocki
2023-01-23 12:09 ` [PATCH 0/3] ACPI: video/apple-gmux: Improve apple-gmux backlight detection Lukas Wunner
2023-01-23 12:38   ` Hans de Goede
2023-01-23 13:58     ` Lukas Wunner
2023-01-23 15:05       ` Hans de Goede
2023-01-23 14:53 ` Aditya Garg
2023-01-24  8:21   ` Orlando Chamberlain [this message]
2023-01-24 10:26     ` Aditya Garg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230124192103.71673c69@redecorated-mbp \
    --to=orlandoch.dev@gmail.com \
    --cc=andy@infradead.org \
    --cc=gargaditya08@live.com \
    --cc=hdegoede@redhat.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=lukas@wunner.de \
    --cc=mgross@linux.intel.com \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=rafael@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox