[PATCH] ACPI/IORT: Increase allocation size up to sizeof(struct acpi_iort_node)

Alexey V. Vissarionov
2023-02-01T02:12:38Z

[-- Attachment #1: Type: text/plain, Size: 1066 bytes --]

The node is a pointer to struct acpi_iort_node, so it's just 4 or 8
bytes, while the structure itself is several times bigger.

Found by ALT Linux Team (altlinux.org) and Linux Verification Center
(linuxtesting.org) using SVACE.

Signed-off-by: Alexey V. Vissarionov <gremlin@altlinux.org>
Fixes: 24e516049360 ("ACPI/IORT: Add support for PMCG")

---

diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c
index 38fb84974f352cc8..edb94b52bf3a21ce 100644
--- a/drivers/acpi/arm64/iort.c
+++ b/drivers/acpi/arm64/iort.c
@@ -1832,7 +1832,8 @@ static int __init iort_add_platform_device(struct acpi_iort_node *node,
if (ops->dev_add_platdata)
ret = ops->dev_add_platdata(pdev);
else
- ret = platform_device_add_data(pdev, &node, sizeof(node));
+ ret = platform_device_add_data(pdev, &node,
+ sizeof(struct acpi_iort_node));

if (ret)
goto dev_put;

--
Alexey V. Vissarionov
gremlin ПРИ altlinux ТЧК org; +vii-cmiii-ccxxix-lxxix-xlii
GPG: 0D92F19E1C0DC36E27F61A29CD17E2B43D879005 @ hkp://keys.gnupg.net

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]