From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28BECC636CD for ; Fri, 10 Feb 2023 18:26:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233062AbjBJS04 (ORCPT ); Fri, 10 Feb 2023 13:26:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52706 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233067AbjBJS0y (ORCPT ); Fri, 10 Feb 2023 13:26:54 -0500 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 370C77CC95; Fri, 10 Feb 2023 10:26:13 -0800 (PST) Received: from lhrpeml500005.china.huawei.com (unknown [172.18.147.206]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4PD2BQ08fnz6J64s; Sat, 11 Feb 2023 02:21:50 +0800 (CST) Received: from localhost (10.81.210.211) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.17; Fri, 10 Feb 2023 18:25:59 +0000 Date: Fri, 10 Feb 2023 18:25:58 +0000 From: Jonathan Cameron To: Dan Williams CC: , Fan Ni , , , , Subject: Re: [PATCH v2 18/20] dax/hmem: Move hmem device registration to dax_hmem.ko Message-ID: <20230210182558.00005853@Huawei.com> In-Reply-To: <167602002771.1924368.5653558226424530127.stgit@dwillia2-xfh.jf.intel.com> References: <167601992097.1924368.18291887895351917895.stgit@dwillia2-xfh.jf.intel.com> <167602002771.1924368.5653558226424530127.stgit@dwillia2-xfh.jf.intel.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.81.210.211] X-ClientProxiedBy: lhrpeml100004.china.huawei.com (7.191.162.219) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Fri, 10 Feb 2023 01:07:07 -0800 Dan Williams wrote: > In preparation for the CXL region driver to take over the responsibility > of registering device-dax instances for CXL regions, move the > registration of "hmem" devices to dax_hmem.ko. > > Previously the builtin component of this enabling > (drivers/dax/hmem/device.o) would register platform devices for each > address range and trigger the dax_hmem.ko module to load and attach > device-dax instances to those devices. Now, the ranges are collected > from the HMAT and EFI memory map walking, but the device creation is > deferred. A new "hmem_platform" device is created which triggers > dax_hmem.ko to load and register the platform devices. > > Tested-by: Fan Ni > Link: https://lore.kernel.org/r/167564543923.847146.9030380223622044744.stgit@dwillia2-xfh.jf.intel.com > Signed-off-by: Dan Williams I'm not particularly familiar with this code, but you changes indeed reflect what you describe above an appear correct to me. Reviewed-by: Jonathan Cameron