Re: [PATCH v1 0/4] Remove use of fw_devlink_purge_absent_suppliers()

Saravana Kannan
2023-03-09T18:05:36Z

Greg,

Don't pull in this series please. It needs more testing from the folks
I cc'ed and it's already breaking things for Martin. This needs more
revisions.

-Saravana

On Wed, Mar 1, 2023 at 1:49 PM Saravana Kannan <saravanak@google.com> wrote:
>
> Yongqin, Martin, Amelie,
>
> We recent refactor of fw_devlink that ends with commit fb42378dcc7f
> ("mtd: mtdpart: Don't create platform device that'll never probe"),
> fw_devlink is smarter and doesn't depend on compatible property. So, I
> don't think these calls are needed anymore. But I don't have these
> devices to test on and be sure and the hardware I use to test changes
> doesn't have this issue either.
>
> Can you please test these changes on the hardware where you hit the
> issue to make sure things work as expected?
>
> Yongqin, If you didn't have the context, this affected hikey960.
>
> Greg,
>
> Let's wait for some tests before we land these.
>
> Thanks,
> Saravana
>
> Cc: Yongqin Liu <yongqin.liu@linaro.org>
> Cc: Sumit Semwal <sumit.semwal@linaro.org>
> Cc: Martin Kepplinger <martin.kepplinger@puri.sm>
> Cc: Amelie Delaunay <amelie.delaunay@foss.st.com>
>
> Saravana Kannan (4):
> usb: typec: stusb160x: Remove use of
> fw_devlink_purge_absent_suppliers()
> usb: typec: tipd: Remove use of fw_devlink_purge_absent_suppliers()
> usb: typec: tcpm: Remove use of fw_devlink_purge_absent_suppliers()
> driver core: Delete fw_devlink_purge_absent_suppliers()
>
> drivers/base/core.c | 16 ----------------
> drivers/usb/typec/stusb160x.c | 9 ---------
> drivers/usb/typec/tcpm/tcpm.c | 9 ---------
> drivers/usb/typec/tipd/core.c | 9 ---------
> include/linux/fwnode.h | 1 -
> 5 files changed, 44 deletions(-)
>
> --
> 2.39.2.722.g9855ee24e9-goog
>