From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
To: <linux-i2c@vger.kernel.org>
Cc: Wolfram Sang <wsa@kernel.org>, Niyas Sait <niyas.sait@linaro.org>,
Klaus Jensen <its@irrelevant.dk>,
Andy Shevchenko <andy@kernel.org>, <linux-acpi@vger.kernel.org>,
Jeremy Kerr <jk@codeconstruct.com.au>,
Matt Johnston <matt@codeconstruct.com.au>,
Shesha Bhushan Sreenivasamurthy <sheshas@marvell.com>,
<linux-cxl@vger.kernel.org>, <linuxarm@huawei.com>,
"Viacheslav A . Dubeyko" <viacheslav.dubeyko@bytedance.com>
Subject: [RFC PATCH 2/6] i2c: aspeed: Use platform_get_irq() instead of opencoding
Date: Thu, 25 May 2023 16:21:59 +0100 [thread overview]
Message-ID: <20230525152203.32190-3-Jonathan.Cameron@huawei.com> (raw)
In-Reply-To: <20230525152203.32190-1-Jonathan.Cameron@huawei.com>
A cleanup in it's own right.
This has the handy side effect of working for ACPI FW as well
(unlike fwnode_irq_get() which works for ARM64 but not x86 ACPI)
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
---
drivers/i2c/busses/i2c-aspeed.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/i2c/busses/i2c-aspeed.c b/drivers/i2c/busses/i2c-aspeed.c
index d3c99c5b3247..04155c9a50a5 100644
--- a/drivers/i2c/busses/i2c-aspeed.c
+++ b/drivers/i2c/busses/i2c-aspeed.c
@@ -19,7 +19,6 @@
#include <linux/kernel.h>
#include <linux/module.h>
#include <linux/of_address.h>
-#include <linux/of_irq.h>
#include <linux/of_platform.h>
#include <linux/platform_device.h>
#include <linux/reset.h>
@@ -1043,7 +1042,7 @@ static int aspeed_i2c_probe_bus(struct platform_device *pdev)
if (ret < 0)
return ret;
- irq = irq_of_parse_and_map(pdev->dev.of_node, 0);
+ irq = platform_get_irq(pdev, 0);
ret = devm_request_irq(&pdev->dev, irq, aspeed_i2c_bus_irq,
0, dev_name(&pdev->dev), bus);
if (ret < 0)
--
2.39.2
next prev parent reply other threads:[~2023-05-25 15:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-25 15:21 [RFC PATCH 0/6] i2c: Enabling use of aspeed-i2c with ACPI Jonathan Cameron
2023-05-25 15:21 ` [RFC PATCH 1/6] i2c: acpi: set slave mode flag Jonathan Cameron
2023-05-26 19:43 ` Andy Shevchenko
2023-05-25 15:21 ` Jonathan Cameron [this message]
2023-05-26 21:06 ` [RFC PATCH 2/6] i2c: aspeed: Use platform_get_irq() instead of opencoding Andy Shevchenko
2023-05-25 15:22 ` [RFC PATCH 3/6] i2c: aspeed: switch to generic fw properties Jonathan Cameron
2023-05-26 21:11 ` Andy Shevchenko
2023-05-30 14:16 ` Jonathan Cameron
2023-05-25 15:22 ` [RFC PATCH 4/6] i2c: aspeed: Set the fwnode for the adap->dev Jonathan Cameron
2023-05-26 21:13 ` Andy Shevchenko
2023-05-25 15:22 ` [RFC PATCH 5/6] HACK: i2c: aspeed: Comment the clock and reset out Jonathan Cameron
2023-05-26 21:16 ` Andy Shevchenko
2023-05-30 14:40 ` Jonathan Cameron
2023-05-25 15:22 ` [RFC PATCH 6/6] HACK: i2c: aspeed: Enable build without COMPILE_TEST Jonathan Cameron
2023-05-30 14:44 ` Jonathan Cameron
2023-05-25 16:18 ` [RFC PATCH 0/6] i2c: Enabling use of aspeed-i2c with ACPI Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230525152203.32190-3-Jonathan.Cameron@huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=andy@kernel.org \
--cc=its@irrelevant.dk \
--cc=jk@codeconstruct.com.au \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=matt@codeconstruct.com.au \
--cc=niyas.sait@linaro.org \
--cc=sheshas@marvell.com \
--cc=viacheslav.dubeyko@bytedance.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox